fix: apply --port/--host overrides before workspace registration#64
Merged
mantoni merged 1 commit intomantoni:mainfrom Mar 11, 2026
Merged
Conversation
When the server is already running and `bdui start --port <N>` is called from a second repo, the port/host env vars were set after the "already running" early-return branch. This caused getConfig() to default to port 3000, sending the workspace registration POST to the wrong port. The registration silently failed and the new workspace never appeared in the picker dropdown. Move the env var assignments before readPidFile() so getConfig() reflects CLI overrides in all code paths.
Owner
|
Thank you! Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bdui start --port <N>is called while the server is already running, the--portand--hostCLI options were applied toprocess.envafter the "already running" early-return branchgetConfig()read the unset env vars and defaulted to port 3000, so the workspace registration POST went to the wrong port and silently failedreadPidFile()sogetConfig()reflects CLI overrides in all code pathsgetConfigmock dynamic to catch regressionsTest plan
npx vitest run server/cli/commands.unit.test.js- all 9 tests pass (including new custom-port test)npx vitest run server/- all 130 server tests passbdui start --port 3030in repo A, thenbdui start --port 3030in repo B - confirmed "Workspace registered" message and workspace appears in picker dropdownter the "already running" early-return branch. This caused getConfig() to default to port 3000, sending the workspace registration POST to the wrong port. The registration silently failed and the new workspace never appeared in the picker dropdown.