Add route callout customization example #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSamaryan
force-pushed
the
ds/feature-route-callout-customization
branch
from
a412601 to
f45d878
Compare
RingerJK
reviewed
Mar 24, 2025
| /** | ||
| * Remove this line if you don't wish to show the route callout feature | ||
| */ | ||
| .isRouteCalloutsEnabled(true) |
There was a problem hiding this comment.
@DSamaryan I missed that 🤔 I supposed we provide "callout enable-disable" API via setting CalloutsAdapter or set it to null
There was a problem hiding this comment.
Discuss it with @dzinad and decided to add this option to RouteLineApiOption as well
There was a problem hiding this comment.
discussed to remove this flag and make lazy callouts calculation or move calculation to RouteLineView class
RingerJK
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New example demonstrates how route callout can be customized + merged previous Route Callout example into example with Route lines
Screen_recording_20250320_143224.mp4