Skip to content

Commit 28e9a78

Browse files
abhishektripabhishektrip
authored
Merge pull request #1218 from mapbox/remove-old-comments-dead-code
Mapbox-centric dead code/old comment cleanup.
2 parents e1727ea + f3de00c commit 28e9a78

File tree

94 files changed

+39
-852
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+39
-852
lines changed

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Map/TileCover.cs

-15
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,9 @@ public static HashSet<UnwrappedTileId> GetWithWebMerc(Vector2dBounds bounds, int
8585
Vector2d swWebMerc = new Vector2d(Math.Max(bounds.SouthWest.x, -Constants.WebMercMax), Math.Max(bounds.SouthWest.y, -Constants.WebMercMax));
8686
Vector2d neWebMerc = new Vector2d(Math.Min(bounds.NorthEast.x, Constants.WebMercMax), Math.Min(bounds.NorthEast.y, Constants.WebMercMax));
8787

88-
//UnityEngine.Debug.LogFormat("swWebMerc:{0}/{1} neWebMerc:{2}/{3}", swWebMerc.x, swWebMerc.y, neWebMerc.x, neWebMerc.y);
89-
9088
UnwrappedTileId swTile = WebMercatorToTileId(swWebMerc, zoom);
9189
UnwrappedTileId neTile = WebMercatorToTileId(neWebMerc, zoom);
9290

93-
//UnityEngine.Debug.LogFormat("swTile:{0} neTile:{1}", swTile, neTile);
94-
9591
for (int x = swTile.X; x <= neTile.X; x++)
9692
{
9793
for (int y = neTile.Y; y <= swTile.Y; y++)
@@ -101,7 +97,6 @@ public static HashSet<UnwrappedTileId> GetWithWebMerc(Vector2dBounds bounds, int
10197
//investigate formulas, this worked before
10298
if (!canonicalTiles.Contains(uwtid.Canonical))
10399
{
104-
//Debug.LogFormat("TileCover.GetWithWebMerc: {0}/{1}/{2}", zoom, x, y);
105100
tiles.Add(uwtid);
106101
canonicalTiles.Add(uwtid.Canonical);
107102
}
@@ -154,16 +149,6 @@ public static UnwrappedTileId WebMercatorToTileId(Vector2d webMerc, int zoom)
154149
double dblX = webMerc.x / Constants.WebMercMax;
155150
double dblY = webMerc.y / Constants.WebMercMax;
156151

157-
//dblX = 1 + dblX;
158-
//dblY = 1 - dblY;
159-
//dblX /= 2;
160-
//dblY /= 2;
161-
//dblX *= tileCount;
162-
//dblY *= tileCount;
163-
//int x = (int)Math.Floor(dblX);
164-
//int y = (int)Math.Floor(dblY);
165-
//return new UnwrappedTileId(zoom, x, y);
166-
167152
int x = (int)Math.Floor((1 + dblX) / 2 * tileCount);
168153
int y = (int)Math.Floor((1 - dblY) / 2 * tileCount);
169154
return new UnwrappedTileId(zoom, x, y);

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Map/UnwrappedTileId.cs

-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ public bool Equals(UnwrappedTileId other)
6363
public override int GetHashCode()
6464
{
6565
return (X << 6) ^ (Y << 16) ^ (Z << 8);
66-
//return X ^ Y ^ Z;
6766
}
6867

6968
public override bool Equals(object obj)

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/MapMatching/MapMatchingResponse.cs

-7
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,6 @@ public class MapMatchingResponse
2121
/// <summary>Simple constructor for deserialization </summary>
2222
public MapMatchingResponse() { }
2323

24-
///// <summary>Constructor for bubbling errors of underlying web request </summary>
25-
//public MapMatchingResponse(ReadOnlyCollection<Exception> requestExceptions)
26-
//{
27-
// _requestExceptions = requestExceptions;
28-
//}
29-
30-
3124
[JsonProperty("code")]
3225
public string Code;
3326
[JsonProperty("message")]

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Platform/Cache/CachingWebFileSource.cs

-1
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,6 @@ private IAsyncRequest requestTileAndCache(string url, string mapId, CanonicalTil
240240
// if the request was successful add tile to all caches
241241
if (!r.HasError && null != r.Data)
242242
{
243-
//UnityEngine.Debug.Log(uri);
244243
string eTag = string.Empty;
245244
DateTime? lastModified = null;
246245

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Platform/Cache/SQLiteCache/SQLiteCache.cs

-10
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,6 @@ name STRING NOT NULL
112112
List<SQLiteConnection.ColumnInfo> colInfoTiles = _sqlite.GetTableInfo(typeof(tiles).Name);
113113
if (0 == colInfoTiles.Count)
114114
{
115-
//sqlite does not support multiple PK columns, create table manually
116-
//_sqlite.CreateTable<tiles>();
117115

118116
string cmdCreateTableTiles = @"CREATE TABLE tiles(
119117
tile_set INTEGER REFERENCES tilesets (id) ON DELETE CASCADE ON UPDATE CASCADE,
@@ -174,7 +172,6 @@ private void openOrCreateDb(string dbName)
174172
{
175173
_dbPath = GetFullDbPath(dbName);
176174
_sqlite = new SQLiteConnection(_dbPath, SQLiteOpenFlags.ReadWrite | SQLiteOpenFlags.Create);
177-
//Debug.LogFormat("SQLiteCache path ----> {0}", _dbPath);
178175
}
179176

180177

@@ -243,7 +240,6 @@ public void Add(string tilesetName, CanonicalTileId tileId, CacheItem item, bool
243240
return;
244241
}
245242

246-
//_sqlite.BeginTransaction();
247243
int rowsAffected = _sqlite.InsertOrReplace(new tiles
248244
{
249245
tile_set = tilesetId.Value,
@@ -263,10 +259,6 @@ public void Add(string tilesetName, CanonicalTileId tileId, CacheItem item, bool
263259
{
264260
Debug.LogErrorFormat("Error inserting {0} {1} {2} ", tilesetName, tileId, ex);
265261
}
266-
finally
267-
{
268-
//_sqlite.Commit();
269-
}
270262

271263
// update counter only when new tile gets inserted
272264
if (!forceInsert)
@@ -299,7 +291,6 @@ private void prune()
299291
{
300292
// no 'ORDER BY' or 'LIMIT' possible if sqlite hasn't been compiled with 'SQLITE_ENABLE_UPDATE_DELETE_LIMIT'
301293
// https://sqlite.org/compile.html#enable_update_delete_limit
302-
// int rowsAffected = _sqlite.Execute("DELETE FROM tiles ORDER BY timestamp ASC LIMIT ?", toDelete);
303294
_sqlite.Execute("DELETE FROM tiles WHERE rowid IN ( SELECT rowid FROM tiles ORDER BY timestamp ASC LIMIT ? );", toDelete);
304295
}
305296
catch (Exception ex)
@@ -393,7 +384,6 @@ private int insertTileset(string tilesetName)
393384
try
394385
{
395386
_sqlite.BeginTransaction(true);
396-
//return _sqlite.Insert(new tilesets { name = tilesetName });
397387
tilesets newTileset = new tilesets { name = tilesetName };
398388
int rowsAffected = _sqlite.Insert(newTileset);
399389
if (1 != rowsAffected)

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Platform/HTTPRequestNonThreaded.cs

-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ namespace Mapbox.Platform {
2929
using System.Linq;
3030
#endif
3131

32-
//using System.Windows.Threading;
33-
3432
internal sealed class HTTPRequestNonThreaded : IAsyncRequest {
3533

3634

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Tests/UnitTests/Editor/MapboxUnitTests_Directions.cs

-3
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public void SerializesAndDeserializesBasic()
3838
string basicReserialized = _directions.Serialize(basicResp);
3939

4040
// Ensure the two match
41-
//UnityEngine.Debug.Log(_basicResponse + System.Environment.NewLine + basicReserialized);
4241
Assert.AreEqual(_basicResponse, basicReserialized);
4342
}
4443

@@ -52,11 +51,9 @@ public void SerializesAndDeserializesWithSteps()
5251
DirectionsResponse withStepsResp = _directions.Deserialize(_responseWithSteps);
5352

5453
// Then deserialize it back to a string.
55-
//string withStepsReserialized = JsonConvert.SerializeObject(withStepsResp);
5654
string withStepsReserialized = _directions.Serialize(withStepsResp);
5755

5856
// Ensure the two match.
59-
//UnityEngine.Debug.Log(_responseWithSteps + System.Environment.NewLine + withStepsReserialized);
6057
Assert.AreEqual(_responseWithSteps, withStepsReserialized);
6158
}
6259

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Tests/UnitTests/Editor/MapboxUnitTests_Geocoder.cs

-8
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,6 @@ internal class GeocoderTest
2424
private string _forwardResponse = "{\"type\":\"FeatureCollection\",\"query\":[\"minneapolis\"],\"features\":[{\"id\":\"place.12871500125885940\",\"type\":\"Feature\",\"text\":\"Minneapolis\",\"place_name\":\"Minneapolis, Minnesota, United States\",\"relevance\":0.99,\"properties\":{\"wikidata\":\"Q36091\"},\"bbox\":[-93.5226520099878,44.7853029900244,-93.1424209928836,45.2129100099882],\"center\":[-93.2655,44.9773],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-93.2655,44.9773]},\"context\":[{\"id\":\"postcode.11389548391063390\",\"text\":\"55415\"},{\"id\":\"region.12225983719702200\",\"text\":\"Minnesota\",\"short_code\":\"US-MN\",\"wikidata\":\"Q1527\"},{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"short_code\":\"us\",\"wikidata\":\"Q30\"}]},{\"id\":\"poi.15555644443768740\",\"type\":\"Feature\",\"text\":\"Minneapolis City Hall\",\"place_name\":\"Minneapolis City Hall, Minneapolis, Minnesota 55415, United States\",\"relevance\":0.99,\"properties\":{\"wikidata\":\"Q1384874\",\"landmark\":true,\"tel\":null,\"address\":null,\"category\":\"other\"},\"center\":[-93.265277777778,44.977222222222],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-93.265277777778,44.977222222222]},\"context\":[{\"id\":\"neighborhood.13081559486410050\",\"text\":\"Greater Central\"},{\"id\":\"place.12871500125885940\",\"text\":\"Minneapolis\",\"wikidata\":\"Q36091\"},{\"id\":\"postcode.11389548391063390\",\"text\":\"55415\"},{\"id\":\"region.12225983719702200\",\"text\":\"Minnesota\",\"short_code\":\"US-MN\",\"wikidata\":\"Q1527\"},{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"short_code\":\"us\",\"wikidata\":\"Q30\"}]},{\"id\":\"poi.6527299549845510\",\"type\":\"Feature\",\"text\":\"Minneapolis Grain Exchange\",\"place_name\":\"Minneapolis Grain Exchange, Minneapolis, Minnesota 55415, United States\",\"relevance\":0.99,\"properties\":{\"wikidata\":\"Q1540984\",\"landmark\":true,\"tel\":null,\"address\":null,\"category\":\"other\"},\"center\":[-93.2636,44.9775],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-93.2636,44.9775]},\"context\":[{\"id\":\"neighborhood.13081559486410050\",\"text\":\"Greater Central\"},{\"id\":\"place.12871500125885940\",\"text\":\"Minneapolis\",\"wikidata\":\"Q36091\"},{\"id\":\"postcode.11389548391063390\",\"text\":\"55415\"},{\"id\":\"region.12225983719702200\",\"text\":\"Minnesota\",\"short_code\":\"US-MN\",\"wikidata\":\"Q1527\"},{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"short_code\":\"us\",\"wikidata\":\"Q30\"}]},{\"id\":\"poi.12655750184890630\",\"type\":\"Feature\",\"text\":\"Minneapolis Armory\",\"place_name\":\"Minneapolis Armory, Minneapolis, Minnesota 55415, United States\",\"relevance\":0.99,\"properties\":{\"wikidata\":\"Q745327\",\"landmark\":true,\"tel\":null,\"address\":null,\"category\":\"other\"},\"center\":[-93.263278,44.975092],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-93.263278,44.975092]},\"context\":[{\"id\":\"neighborhood.13081559486410050\",\"text\":\"Greater Central\"},{\"id\":\"place.12871500125885940\",\"text\":\"Minneapolis\",\"wikidata\":\"Q36091\"},{\"id\":\"postcode.11389548391063390\",\"text\":\"55415\"},{\"id\":\"region.12225983719702200\",\"text\":\"Minnesota\",\"short_code\":\"US-MN\",\"wikidata\":\"Q1527\"},{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"short_code\":\"us\",\"wikidata\":\"Q30\"}]},{\"id\":\"poi.4855757554573390\",\"type\":\"Feature\",\"text\":\"Minneapolis Chain of Lakes Park\",\"place_name\":\"Minneapolis Chain of Lakes Park, Minneapolis, Minnesota 55405, United States\",\"relevance\":0.99,\"properties\":{\"wikidata\":null,\"landmark\":true,\"tel\":null,\"address\":null,\"category\":\"park\",\"maki\":\"picnic-site\"},\"bbox\":[-93.330260720104,44.9504758437682,-93.3013567328453,44.969400319872],\"center\":[-93.310259,44.959942],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-93.310259,44.959942]},\"context\":[{\"id\":\"neighborhood.12530456224376080\",\"text\":\"Kenwood\"},{\"id\":\"place.12871500125885940\",\"text\":\"Minneapolis\",\"wikidata\":\"Q36091\"},{\"id\":\"postcode.10829535691218220\",\"text\":\"55405\"},{\"id\":\"region.12225983719702200\",\"text\":\"Minnesota\",\"short_code\":\"US-MN\",\"wikidata\":\"Q1527\"},{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"short_code\":\"us\",\"wikidata\":\"Q30\"}]}],\"attribution\":\"NOTICE: \u00A9 2016 Mapbox and its suppliers. All rights reserved. Use of this data is subject to the Mapbox Terms of Service (https://www.mapbox.com/about/maps/). This response and the information it contains may not be retained.\"}";
2525
private string _reverseResponse = "{\"type\":\"FeatureCollection\",\"query\":[-77.0268808,38.925326999999996],\"features\":[{\"id\":\"address.5375777428110760\",\"type\":\"Feature\",\"text\":\"11th St NW\",\"place_name\":\"2717 11th St NW, Washington, District of Columbia 20001, United States\",\"relevance\":1.0,\"properties\":{},\"center\":[-77.026824,38.925306],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-77.026824,38.925306]},\"address\":\"2717\",\"context\":[{\"id\":\"neighborhood.11736072639395000\",\"text\":\"Pleasant Plains\"},{\"id\":\"place.12334081418246050\",\"text\":\"Washington\",\"wikidata\":\"Q61\"},{\"id\":\"postcode.3526019892841050\",\"text\":\"20001\"},{\"id\":\"region.6884744206035790\",\"text\":\"District of Columbia\",\"short_code\":\"US-DC\",\"wikidata\":\"Q61\"},{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"wikidata\":\"Q30\",\"short_code\":\"us\"}]},{\"id\":\"neighborhood.11736072639395000\",\"type\":\"Feature\",\"text\":\"Pleasant Plains\",\"place_name\":\"Pleasant Plains, Washington, 20001, District of Columbia, United States\",\"relevance\":1.0,\"properties\":{},\"bbox\":[-77.0367101373528,38.9177500315001,-77.0251464843832,38.9273657639],\"center\":[-77.0303,38.9239],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-77.0303,38.9239]},\"context\":[{\"id\":\"place.12334081418246050\",\"text\":\"Washington\",\"wikidata\":\"Q61\"},{\"id\":\"postcode.3526019892841050\",\"text\":\"20001\"},{\"id\":\"region.6884744206035790\",\"text\":\"District of Columbia\",\"short_code\":\"US-DC\",\"wikidata\":\"Q61\"},{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"wikidata\":\"Q30\",\"short_code\":\"us\"}]},{\"id\":\"place.12334081418246050\",\"type\":\"Feature\",\"text\":\"Washington\",\"place_name\":\"Washington, District of Columbia, United States\",\"relevance\":1.0,\"properties\":{\"wikidata\":\"Q61\"},\"bbox\":[-77.1197590084041,38.8031129900659,-76.90939299,38.9955480080759],\"center\":[-77.0366,38.895],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-77.0366,38.895]},\"context\":[{\"id\":\"postcode.3526019892841050\",\"text\":\"20001\"},{\"id\":\"region.6884744206035790\",\"text\":\"District of Columbia\",\"short_code\":\"US-DC\",\"wikidata\":\"Q61\"},{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"wikidata\":\"Q30\",\"short_code\":\"us\"}]},{\"id\":\"postcode.3526019892841050\",\"type\":\"Feature\",\"text\":\"20001\",\"place_name\":\"20001, District of Columbia, United States\",\"relevance\":1.0,\"properties\":{},\"bbox\":[-77.028082,38.890834,-77.007177,38.929058],\"center\":[-77.018017,38.909197],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-77.018017,38.909197]},\"context\":[{\"id\":\"region.6884744206035790\",\"text\":\"District of Columbia\",\"short_code\":\"US-DC\",\"wikidata\":\"Q61\"},{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"wikidata\":\"Q30\",\"short_code\":\"us\"}]},{\"id\":\"region.6884744206035790\",\"type\":\"Feature\",\"text\":\"District of Columbia\",\"place_name\":\"District of Columbia, United States\",\"relevance\":1.0,\"properties\":{\"short_code\":\"US-DC\",\"wikidata\":\"Q61\"},\"bbox\":[-77.2081379659453,38.7177026348658,-76.909393,38.995548],\"center\":[-76.990661,38.89657],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-76.990661,38.89657]},\"context\":[{\"id\":\"country.12862386939497690\",\"text\":\"United States\",\"wikidata\":\"Q30\",\"short_code\":\"us\"}]},{\"id\":\"country.12862386939497690\",\"type\":\"Feature\",\"text\":\"United States\",\"place_name\":\"United States\",\"relevance\":1.0,\"properties\":{\"wikidata\":\"Q30\",\"short_code\":\"us\"},\"bbox\":[-179.330950579,18.765563302,179.959578044,71.540723637],\"center\":[-97.922211,39.381266],\"geometry\":{\"type\":\"Point\",\"coordinates\":[-97.922211,39.381266]}}],\"attribution\":\"NOTICE: © 2016 Mapbox and its suppliers. All rights reserved. Use of this data is subject to the Mapbox Terms of Service (https://www.mapbox.com/about/maps/). This response and the information it contains may not be retained.\"}";
2626

27-
28-
[SetUp]
29-
public void Setup()
30-
{
31-
//MapboxAccess.Instance.ToString();
32-
}
33-
34-
3527
[Test]
3628
public void SerializesAndDeserializesReverse()
3729
{

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Tests/UnitTests/Editor/MapboxUnitTests_Map.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ public void TileMax()
185185

186186
map.SetVector2dBoundsZoom(Vector2dBounds.World(), 2);
187187
map.Update();
188-
Assert.Less(map.Tiles.Count, Map<RasterTile>.TileMax); // 16
188+
Assert.Less(map.Tiles.Count, Map<RasterTile>.TileMax);
189189

190190
// Should stay the same, ignore requests.
191191
map.SetVector2dBoundsZoom(Vector2dBounds.World(), 5);

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Tests/UnitTests/Editor/MapboxUnitTests_MapMatcher.cs

-76
Original file line numberDiff line numberDiff line change
@@ -687,82 +687,6 @@ private void commonBasicResponseAsserts(MapMatchingResponse matchingResponse)
687687
Assert.IsNotNull(matchingResponse.Matchings[0].Legs, "Legs are NULL");
688688
Assert.GreaterOrEqual(matchingResponse.Matchings[0].Legs.Count, 1, "1st match has no legs");
689689
}
690-
691-
692-
693-
#region disabledTests
694-
695-
//These tests don't work as we don't access the raw response and cannot verify the digits returned by the API
696-
/*
697-
[UnityTest]
698-
public IEnumerator GeometriesWith5Digits()
699-
{
700-
701-
MapMatchingResource resource = new MapMatchingResource();
702-
resource.Coordinates = new Vector2d[]
703-
{
704-
new Vector2d(48.1974721043879,16.36202484369278),
705-
new Vector2d(48.197922645046546,16.36285901069641)
706-
};
707-
//no extra parameters needed: 5 digits default
708-
709-
MapMatcher mapMatcher = new MapMatcher(_fs);
710-
MapMatchingResponse matchingResponse = null;
711-
mapMatcher.Match(
712-
resource,
713-
(MapMatchingResponse response) =>
714-
{
715-
matchingResponse = response;
716-
}
717-
);
718-
719-
IEnumerator enumerator = _fs.WaitForAllRequests();
720-
while (enumerator.MoveNext()) { yield return null; }
721-
722-
commonBasicResponseAsserts(matchingResponse);
723-
724-
string locationX = matchingResponse.Matchings[0].Geometry[0].x.ToString(System.Globalization.CultureInfo.InvariantCulture);
725-
locationX = locationX.Substring(locationX.IndexOf(".") + 1);
726-
Assert.AreEqual(5, locationX.Length, "Precision not as expected");
727-
}
728-
729-
730-
[UnityTest]
731-
public IEnumerator GeometriesWith6Digits()
732-
{
733-
734-
MapMatchingResource resource = new MapMatchingResource();
735-
resource.Coordinates = new Vector2d[]
736-
{
737-
new Vector2d(48.1974721043879,16.36202484369278),
738-
new Vector2d(48.197922645046546,16.36285901069641)
739-
};
740-
resource.Geometries = Geometries.Polyline6;
741-
742-
MapMatcher mapMatcher = new MapMatcher(_fs);
743-
MapMatchingResponse matchingResponse = null;
744-
mapMatcher.Match(
745-
resource,
746-
(MapMatchingResponse response) =>
747-
{
748-
matchingResponse = response;
749-
}
750-
);
751-
752-
IEnumerator enumerator = _fs.WaitForAllRequests();
753-
while (enumerator.MoveNext()) { yield return null; }
754-
755-
commonBasicResponseAsserts(matchingResponse);
756-
757-
string locationX = matchingResponse.Matchings[0].Geometry[0].x.ToString(System.Globalization.CultureInfo.InvariantCulture);
758-
locationX = locationX.Substring(locationX.IndexOf(".") + 1);
759-
Assert.AreEqual(6, locationX.Length, "Precision not as expected");
760-
}
761-
*/
762-
763-
#endregion
764-
765-
766690
}
767691
}
768692

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Tests/UnitTests/Editor/MapboxUnitTests_PolylineToGeoCoordinateListConverter.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace Mapbox.MapboxSdkCs.UnitTest
1717
[TestFixture]
1818
internal class PolylineToVector2dListConverterTest
1919
{
20-
20+
2121
// (38.5, -120.2), (40.7, -120.95), (43.252, -126.453)
2222
private readonly List<Vector2d> _polyLineObj = new List<Vector2d>()
2323
{

‎sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Tests/UnitTests/Editor/MapboxUnitTests_SQLiteCache.cs

-9
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ public void Cleanup()
7676
{
7777
if (null != _cache)
7878
{
79-
//_cache.Clear();
8079
_cache.Dispose();
8180
_cache = null;
8281
}
@@ -233,14 +232,6 @@ private IEnumerator InsertCoroutine(string tileSetName, bool forceInsert, HashSe
233232

234233
List<long> elapsed = simpleInsert(tileSetName, forceInsert, tileIds);
235234

236-
//List<long> elapsed = new List<long>();
237-
//foreach (CanonicalTileId tileId in tileIds)
238-
//{
239-
// HashSet<CanonicalTileId> tmpIds = new HashSet<CanonicalTileId>(new CanonicalTileId[] { tileId });
240-
// elapsed.AddRange(simpleInsert(tileSetName, forceInsert, tmpIds));
241-
// yield return null;
242-
//}
243-
244235
ued.Log(string.Format("coroutine [{0}] finished", tileSetName));
245236
logTime(tileSetName, elapsed);
246237
}

0 commit comments

Comments
 (0)