Api ui integration vector texturing #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GUILayout.Popup-centric Begin/EndChangeCheck-encapsulated EditorHelper.CheckForModifiedProperty calls.
…I calls in vector-centric property drawers. - Wrapped CheckForModifiedProperty calls in EndChangeCheck conditional checks. Added color-coded debug message for Vector layer in AbstractMap. - Added System.EventHandler LayerVisualizerHasChanged and OnUpdateLayerVisualizer method to LayerVisualizerBase. - Added System.EventHandler TileFactoryHasChanged and UpdateTileFactory method to AbstractTileFactory. - Chain of EventHandlers = VectorLayerVisualizer -> VectorTileFactory -> VectorLayer -> AbstractMap
… moved tile factory update/change event vars/methods into events section.
* Fix PropertyDrawer errors when adding new layer. * Fix errors on adding filters. * Removed commented/dead property.serializedObject.Update() calls.
…some reason, this is not working with EditorHelper.CheckForModifiedProperty; setting HasChanged manually does work.
…tric UI changes. - Sequential Vector UI changes will cause over/re-registration for event handlers. We need to fix this. - Added debug message and comment re: register/unregistering for EventHandlers...
…pdatePOC * commit 'b88ed6d0ae1f7a55197456143f9cd25c0de18bbf': Map editor fix (#980) Terrain section event refactor apply property changes at end of gui (#1009) fix an issue where TerrainFactoryBase didn't respect "none" terrain option (#1006) API's for runtime editing. (#1005) # Conflicts: # sdkproject/Assets/Mapbox/Unity/Editor/PropertyDrawers/ElevationLayerPropertiesDrawer.cs # sdkproject/Assets/Mapbox/Unity/Map/AbstractMap.cs # sdkproject/Assets/Mapbox/Unity/SourceLayers/TerrainLayer.cs
…ntegration * commit 'd988e2e1d1747450788e40446e4d8eeac11ecba5': VectorUpdate is now working; map redraws vector section on vector-centric UI changes. - Sequential Vector UI changes will cause over/re-registration for event handlers. We need to fix this. - Added debug message and comment re: register/unregistering for EventHandlers... Changing DataSource in map features section now triggers update. For some reason, this is not working with EditorHelper.CheckForModifiedProperty; setting HasChanged manually does work. Enabling/disabling map feature checkboxes now fires UI update events. Adding/removing map features now triggers update event. Removed property.serializedObject.Update call at beginning of OnGUI. Removed unused delegate and method. Added UI update checks for Behavior Modifier section. Fix ui errors vector section (#1011) Added support for change events in vector filter section. Removed unused EndChangeCheck call in BehaviorModifiersSectionDrawer; moved tile factory update/change event vars/methods into events section. Adding/removing mesh and/or gameplay modifiers now triggers change events. Temporarily disabled Vector Update business in abstract map. - Added property.serializedObject.Update() calls to beginning of OnGUI calls in vector-centric property drawers. - Wrapped CheckForModifiedProperty calls in EndChangeCheck conditional checks. Added color-coded debug message for Vector layer in AbstractMap. - Added System.EventHandler LayerVisualizerHasChanged and OnUpdateLayerVisualizer method to LayerVisualizerBase. - Added System.EventHandler TileFactoryHasChanged and UpdateTileFactory method to AbstractTileFactory. - Chain of EventHandlers = VectorLayerVisualizer -> VectorTileFactory -> VectorLayer -> AbstractMap Replaced bare EditorHelper.CheckForModifiedProperty calls with EditorGUILayout.Popup-centric Begin/EndChangeCheck-encapsulated EditorHelper.CheckForModifiedProperty calls. # Conflicts: # sdkproject/Assets/Mapbox/Unity/MeshGeneration/Factories/AbstractTileFactory.cs # sdkproject/Assets/Mapbox/Unity/SourceLayers/VectorLayer.cs
…nd latlng settings (#1028)
* add two SetProperties methods to terrain and image layer to set multiple properties at once * add comments to SetProperties methods
* move poi api methods to vector layer add basic comments for terrain/image factory api methods * fix a broken method reference * change poi api methods to fire update events and work with runtime calls
…integration-vector-section
…-vector-texturing
… to API calls in VectorSubLayerProperties.
abhishektrip
approved these changes
Sep 28, 2018
abhishektrip
added a commit
that referenced
this pull request
Sep 28, 2018
* develop: Api ui integration vector texturing (#1031) # Conflicts: # sdkproject/Assets/Mapbox/Unity/LayerProperties/VectorSubLayerProperties.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Example: Closes #832. Relates to #832.
Description of changes
Vector texturing section API methods.
QA checklists
<summary>description as well as description of parameters.Reviewers
Tag your reviewer(s). Choose wisely.