Use UniAndroid to check permission status #1866
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the existing implementation, `_gotPermissionRequestResponse` is not reliably set when the user sets permission, which can leave the application in a broken state that can only be resolved by force-quitting and restarting. Using UniAndroid instead seems to fix the issue and results in the application being in a working state after the user accepts the permission request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing implementation,
_gotPermissionRequestResponseis not reliably set when the user sets permission, which can leave the application in a broken state that can only be resolved by force-quitting and restarting. Using UniAndroid instead seems to fix the issue and results in the application being in a working state after the user accepts the permission request.Related issue
Example: Closes #832. Relates to #832.
Description of changes
Your text here!
QA checklists
<summary>description as well as description of parameters.Reviewers
Tag your reviewer(s). Choose wisely.