-
-
Notifications
You must be signed in to change notification settings - Fork 910
chore(deps-dev): bump jsdom and @types/jsdom #6497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
Continued from |
Really hoped that this would be fixed after recreating - guess we're not done debugging jsdom. |
If they haven't released a new version I'm not sure how anything can be fixed... Am I missing anything? |
There was a new version released of https://github.com/asamuzaK/domSelector (npm) after this fix was applied. The new version of dom-selector should be within the range that the jsdom rely on, so jsdom 27 should be getting the updated version of it, and as far as I can tell (by looking at lockfile / node_modules) that is the case. |
Ahh, I see what you mean - I do see it in the lock file: dom-selector: 6.6.1. |
A fresh install of jsdom 27 no longer trips over the click repro i made, so the issue appear to have been solved in that specific case, causing me to think the changes to new dom-selector versions does pass through. Unfortunately, my repro appear to only represent one of potentially several issues we see - so another repro will likely be necessary. |
I've submitted a reproduction, that show jsdom 26 can pick up on a class that's removed after a 1s timeout, and jsdom 27 doesn't pick up on the change. This should at least showcase the issue we see with the cooperative gestures. |
@dependabot recreate |
Bumps [jsdom](https://github.com/jsdom/jsdom) and [@types/jsdom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jsdom). These dependencies needed to be updated together. Updates `jsdom` from 26.1.0 to 27.0.0 - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md) - [Commits](jsdom/jsdom@26.1.0...27.0.0) Updates `@types/jsdom` from 21.1.7 to 27.0.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jsdom) --- updated-dependencies: - dependency-name: jsdom dependency-version: 27.0.0 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: "@types/jsdom" dependency-version: 27.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
3fe63e1
to
8623c42
Compare
Alright, two rounds of JSDOM 27 repros and fixes, and we're now down to 1 failing test 🎉 For the last issue (cooperative gestures overlay), I've made another repro here: |
Bumps jsdom and @types/jsdom. These dependencies needed to be updated together.
Updates
jsdom
from 26.1.0 to 27.0.0Release notes
Sourced from jsdom's releases.
... (truncated)
Changelog
Sourced from jsdom's changelog.
Commits
f2a505d
Version 27.0.0ab384d4
Update dependencies and dev dependenciesff31107
Add passing :nth-child() in shadow DOM regresssion test4e92a8e
Add passing :scope() in :not() regression testc3d6940
Version 27.0.0-beta.38073bae
Use "v" instead of "u" for the pattern="" attributed77ffd0
Implement customElements.getName()ac385f9
Fix reconfigure() not updating base URL caches3ccd5de
Update tough-cookie to v6c2de8bd
Address CSS regressions in v27 betaUpdates
@types/jsdom
from 21.1.7 to 27.0.0Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)