Fix RTL plugin crash with empty formatted text sections #6545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes crash when using RTL text plugin with formatted
text-field
expressions where all sections evaluate to empty strings.Closes #6444
Problem
When using the RTL text plugin (
@mapbox/[email protected]
) with a formattedtext-field
where all sections are empty (e.g., bothname
andref
are null), the application crashes with:Root Cause
The RTL plugin's
processStyledBidirectionalText
can return either:[text, sectionIndex]
(expected format){text, sectionIndex}
(some plugin versions/edge cases)The shaping code in
src/symbol/shaping.ts
only handled tuples, causingtaggedLine.text
to beundefined
when objects were returned, leading to crashes when later code accessedthis.text.length
.Solution
Added defensive normalization logic (lines 331-361 in
shaping.ts
) to:[text, sectionIndex]
and object{text, sectionIndex}
formats''
for text, empty array[]
for sectionIndexTesting
@mapbox/[email protected]
Test Cases Verified
Checklist
text
property for formatted text with multiple empty sections and right to left plugin #6444