Skip to content

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Oct 15, 2025

Launch Checklist

This PR will introduce support for MLT format.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM
Copy link
Collaborator Author

HarelM commented Oct 15, 2025

@Salkin975 I've opened the following branch for integration, and this PR to see that we keep this branch working and up-to-date with the main branch.:
https://github.com/maplibre/maplibre-gl-js/tree/mlt

I tried to copy over the code from your branch but I'm not sure this is the right approach to solve it.
Most of the code is duplicated between mlt and vector source when there's no real need to copy it.

I would recommend as an initial step to only try and make mlt work in maplibre without optimizing the buckets and other things.
Once we have it working with some basic tests for lines, fill, symbols etc, we can start implementing the optimizations that are needed.
What do you think?

Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 31.42857% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.13%. Comparing base (b906c04) to head (d38de93).
⚠️ Report is 10 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/source/mlt/mlt_vector_tile.ts 25.39% 47 Missing ⚠️
src/source/vector_tile_worker_source.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6570      +/-   ##
==========================================
+ Coverage   96.10%   96.13%   +0.02%     
==========================================
  Files         291      292       +1     
  Lines       35337    35410      +73     
  Branches     8646     8661      +15     
==========================================
+ Hits        33962    34041      +79     
+ Misses       1375     1369       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HarelM HarelM mentioned this pull request Oct 15, 2025
10 tasks
Copy link

socket-security bot commented Oct 15, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​maplibre/​mlt@​0.0.1-alpha.9100100100100100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support MapLibre Tiles (MLT)

1 participant