First cut at native C++ MLT loader #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix decoding bugs.
Rework handling of present bits, still not quite right.
Don't expand string columns based on present bits. More validation checks. Better JSON diffs.
Consider zeros equivalent to missing values in JSON.
louwers
requested changes
Feb 11, 2025
louwers
reviewed
Feb 11, 2025
|
@louwers Should I move |
You can leave it in |
louwers
reviewed
Feb 12, 2025
… values Improve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all the necessary types and encodings to load the tiles in
test/expected.Currently builds only with CMake.
Depends on protozero (for tileset metadata decoding), FastPFoR, and (optionally) nlohmann/json.
When dumped to GeoJSON, results match the output of the nodejs test, after being modified slightly to produce that output.