Skip to content

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Oct 16, 2025

The rust/mlt branch is no longer capable of parsing current data format, and should be migrated to the newer rust/mlt-nom implementation. For now, I renamed rust.yml into rust-legacy.yml, which at some point will be deleted.

@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 03:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Rust CI workflow from the legacy rust/mlt implementation to the newer rust/mlt-nom variant. The original workflow is preserved as rust-legacy.yml for potential future reference, while rust.yml is updated to use the mlt-nom directory.

Key Changes:

  • Updated rust.yml to point all jobs to ./rust/mlt-nom working directory
  • Created rust-legacy.yml preserving the original workflow pointing to ./rust/mlt

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/rust.yml Updated working directory from ./rust/mlt to ./rust/mlt-nom across all three jobs (test, test-msrv, coverage)
.github/workflows/rust-legacy.yml New file preserving the original workflow configuration pointing to ./rust/mlt

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.34%. Comparing base (b8e0f4a) to head (ee74170).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   65.59%   57.34%   -8.25%     
==========================================
  Files          19       30      +11     
  Lines        1735     2288     +553     
  Branches     1735     2288     +553     
==========================================
+ Hits         1138     1312     +174     
- Misses        556      878     +322     
- Partials       41       98      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The `rust/mlt` branch is no longer capable of parsing current data format, and should be migrated to the newer `rust/mlt-nom` implementation. For now, I renamed `rust.yml` into `rust-legacy.yml`, which at some point will be deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants