Format markdown#555
Open
cthoyt wants to merge 2 commits into
Open
Conversation
cthoyt
requested review from
gouttegd and
matentzn
and removed request for
gouttegd
gouttegd
requested changes
May 28, 2026
| 2. Sort the list of values in lexicographical order and iterate over the | ||
| sorted values. For each value _V_, append `N:V`, where _N_ is the | ||
| length of _V_. | ||
| 3. Append `)`. |
Contributor
There was a problem hiding this comment.
This change is incorrect. There is a reason for this additional space in front of those numbers: it’s to indicate that we are dealing with “sub-sub-items” (a list within a list within a list).
This is what allows the (correct) existing rendering:
This change completely messes up the rendering:
| extension and _N_ is the length of the property. | ||
| 2. Use the table below to transform the extension value into a string _V_ | ||
| based on the declared type of the extension. | ||
| 3. Append `N:V)`, where _N_ is the length of the string value _V_. |
Contributor
There was a problem hiding this comment.
Same as above.
Correct rendering (before the change):
Wrong rendering (after this change):
gouttegd
requested changes
May 28, 2026
| 2. Iterate over all slots of the `Mapping` class, in the order in which they are | ||
| [listed](../Mapping/#slots) in the LinkML model. Exclude the `record_id` slot | ||
| and the `mapping_cardinality` slot. For all other slots: | ||
| 1. If the slot has no value for the mapping record to hash, skip to next |
Contributor
There was a problem hiding this comment.
This is still incorrect. Here is the rendering:
This time it’s the sub-items that are not recognised as such.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs
npx prettier --check --prose-wrap always --write **/*.mdto format all markdown in the repo. It doesn't change any content (except one minor typo and one section where I converted italics at the beginning of paragraphs into proper headers)This PR does not add any linting checks to CI (yet, maybe in a follow-up)
There are many times I wanted to do typo checks/editing/revising but wasn't able to because the diff would have been too big because of using single lines. This enables me to more effectively edit and revise