Adroffner #4
Open
Adroffner #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to make the unit test "./tests/" directory find them.
This will make it easier to improve test coverage with exception handling cases.
…exception handling.
The unit tests match this rule now.
…code. Also, improve test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my ABC Bank project for your review.
I have used python3.4 to develop the code. Also, I added comments to every method suitable for auto-documentation (Sphinx as I recall).
I replaced the "nose" unit test with the standard "unittest" module. "unittest" is more flexible since it has setUp(), tearDown(), & ways to test raised exceptions. It also has the "unittest.mock" library to pretend we have a database, etc (did not apply here). You can still run the ./nosetests script on it.
I also verified test code coverage, using coverage.py. Here;s is the current result:
$ nosetests --with-coverage ./tests/
.........................
Name Stmts Miss Cover Missing
abcbank 0 0 100%
abcbank.account 45 0 100%
abcbank.bank 13 0 100%
abcbank.customer 33 0 100%
abcbank.transaction 15 1 93% 32
TOTAL 106 1 99%
Ran 25 tests in 0.008s
OK