fix: pedantic **foo:** and **"word"** emphasis parsing#3999
Open
waiter wants to merge 2 commits into
Open
Conversation
|
@waiter is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hongarc
reviewed
Jul 16, 2026
| .replace(/punctSpace/g, _punctuationOrSpace).getRegex(); | ||
|
|
||
| /** Quote chars for pedantic rule 6 lookbehind; includes both straight and curly forms. */ | ||
| const closeQuoteClass = '["\u201c\u201d\u2018\u2019\']'; |
There was a problem hiding this comment.
openQuoteClass and closeQuoteClass are asymmetric (” only exists in the latter). If that's intentional, I'd add a test to pin the behavior; otherwise it looks like an easy regression candidate.
| + '|(?!\\*)[\\s](\\*+)(?=notPunctSpace)' // (3) ***a can only be Left Delimiter (whitespace required; not #***a) | ||
| + '|[\\s](\\*+)(?!\\*)(?=punct)' // (4) ***# can only be Left Delimiter | ||
| + '|(?!\\*)punct(\\*+)(?!\\*)(?=punct)' // (5) #***# can be either Left or Right Delimiter | ||
| + '|closeQuoteLookbehind(?:(?!\\*)punct|notPunctSpace)(\\*+)(?!\\*)(?=notPunctSpace)'; // (6) a***a, #***a, and :** (e.g. **foo:**bar) |
There was a problem hiding this comment.
This changes pedantic parsing for some "aa-style edge cases. The new behavior may well be preferable, but since it's a silent regression, I'd add a regression test to explicitly pin the intended behavior
Author
UziTech
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version:
18.0.5 / master
Markdown flavor: Markdown.pl / pedantic
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.