docs: replace nonexistent test:all script with npm test - #4054
Open
FirmaSpring wants to merge 1 commit into
Open
docs: replace nonexistent test:all script with npm test#4054FirmaSpring wants to merge 1 commit into
FirmaSpring wants to merge 1 commit into
Conversation
The contributor checklist references npm run test:all, but no such script exists in package.json Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
|
@FirmaSpring is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The contributor checklist in
docs/CONTRIBUTING.mdtells contributors to runnpm run test:all, but no script namedtest:allexists inpackage.json. Following the documented step fails:Solution
Replace
npm run test:allwithnpm testin the checklist. Thetestscript inpackage.jsonruns the full suite (build:reset,build:docs,test:specs,test:unit,test:umd,test:cjs,test:types,test:lint), which is the complete check a contributor needs before submitting.Verification
test:alldoes not exist inpackage.json(rg '"test' package.jsonlists all test scripts; none istest:all).npm run test:allfails with "Missing script".npm testis the full-suite script defined inpackage.json.