Improved synchronization of the audio with the display of letters#2
Open
PrimCarol wants to merge 1 commit intomarkv12:masterfrom
Open
Improved synchronization of the audio with the display of letters#2PrimCarol wants to merge 1 commit intomarkv12:masterfrom
PrimCarol wants to merge 1 commit intomarkv12:masterfrom
Conversation
Improved sound playback for each letter, now the sound plays once a letter has been displayed. Before, the sound was played at the beginning of the interpretation of each letter, regardless of how long it took to be displayed, being out of sync with the audio and the display of the letter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved sound playback for each letter, now the sound plays once a letter has been displayed. Before, the sound was played at the beginning of the interpretation of each letter, regardless of how long it took to be displayed, being out of sync with the audio and the display of the letter.
And a small sanity check in case you don't want or forget to put an audio.