-
Notifications
You must be signed in to change notification settings - Fork 13
fix: update prometheus-client dependency Fix #60 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdded a single dependency, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/qdrant-loader/pyproject.toml (1)
67-67: Consider adding an upper bound version constraint.The version constraint
>=0.19.0is permissive and allows any future major version, which could introduce breaking changes. For production dependencies, consider specifying an upper bound.Apply this diff to add an upper bound (verify the appropriate upper bound based on your compatibility testing):
- "prometheus-client>=0.19.0" + "prometheus-client>=0.19.0,<2.0.0"Alternatively, if you want to be more conservative and match the current major version:
- "prometheus-client>=0.19.0" + "prometheus-client>=0.19.0,<1.0.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/qdrant-loader/pyproject.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: martin-papy
Repo: martin-papy/qdrant-loader PR: 43
File: docs/developers/testing/README.md:36-40
Timestamp: 2025-08-12T09:02:25.128Z
Learning: Both packages/qdrant-loader and packages/qdrant-loader-mcp-server directories contain pyproject.toml files at their root level, making them installable with pip install -e for editable development installations.
📚 Learning: 2025-08-12T09:02:25.128Z
Learnt from: martin-papy
Repo: martin-papy/qdrant-loader PR: 43
File: docs/developers/testing/README.md:36-40
Timestamp: 2025-08-12T09:02:25.128Z
Learning: Both packages/qdrant-loader and packages/qdrant-loader-mcp-server directories contain pyproject.toml files at their root level, making them installable with pip install -e for editable development installations.
Applied to files:
packages/qdrant-loader/pyproject.toml
🔇 Additional comments (1)
packages/qdrant-loader/pyproject.toml (1)
67-67: Based on my verification, I can now provide the rewritten review comment:
prometheus-client dependency addition is verified and appropriate.
The addition of
"prometheus-client>=0.19.0"to runtime dependencies is correct. Verification confirmsprometheus_clientis actively imported and used at runtime:
- Direct import in
packages/qdrant-loader/src/qdrant_loader/core/monitoring/prometheus_metrics.py(Counter, Gauge, Histogram, start_http_server)- Used across multiple runtime workers:
upsert_worker.py,embedding_worker.py,chunking_worker.py, andasync_ingestion_pipeline.py- Not limited to tests or optional features
The version constraint
>=0.19.0is permissive but acceptable for a stable library. The dependency move from dev-only to runtime resolves the reported ModuleNotFoundError appropriately.
Pull Request
Summary
Fixed missing prometheus-client dependency by adding
"prometheus-client>=0.19.0"to the main dependencies section inpyproject.toml, as this is a runtime requirement, not a development-only dependency.Type of change
Docs Impact (required for any code or docs changes)
docs/?python website/build.py+python website/check_links.py)Testing
Test steps:
pip install qdrant-loaderqdrant-loader --helpTest Results:
No ModuleNotFoundError: No module named 'prometheus_client' occurred.
Checklist
pytest -v)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.