Simplify leveled_tree - #495
Open
martinsumner wants to merge 4 commits into
Open
Conversation
Extend eunit testing to better prove relative performance. Handle issues with inefficient ++
Remove skpl and old tree type
Also strip out redundant functions
Owner
Author
|
Although there is some micro-optimisation in the change, overall there is no significant impact on performance in the perf_SUITE test: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #494
Simplify the implementation of leveled_tree, removing redundant code (other than the option for a pure gb_trees implementation).