Fix invalid volumeMounts rendering in sidekiq and web - #66
Open
mydoomfr wants to merge 1 commit into
Open
Conversation
Signed-off-by: Benjamin Pinchon <dev@mdfr.me>
mydoomfr
force-pushed
the
fix-volume-mounts
branch
from
July 28, 2026 21:34
27f58db to
76f304e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65
Problem
Setting
volumeMounts/volumesin values breaks thewebandsidekiqDeployments. Themastodon.volumeMountsandmastodon.volumeshelpers emit their own key and indentation , but the deployment templates already print the key... so we end up with a duplicate nestedvolumeMounts:and the install fails withexpected list, got map.This is the same bug as #23 (fixed for
streamingin #24) but reintroduced for web/sidekiq by the helper refactor in #46Fix
The helpers now only emit list items (same pattern as the
mastodon.pvc.*helpers), so the key is written in exactly one placeAnd as a side effect, this also restores the elasticsearch CA secret mount when
elasticsearch.caSecret.nameis set without uservolumeMounts