Update README.md#641
Open
Ashraf-wan wants to merge 2 commits into
Open
Conversation
makes it easier to compile by adding apt build-dep to install all necessary dependencies atril needs.
added yelp-tools and mate-common for autogen.sh
Member
|
Note that apt-build is part of apt, which only exists on Debian based distros. We should make a note of that so users of other distros don't wonder why this gets |
Author
|
Tbh i made these changes while compiling the 1.26.1 for a ctf. Thx |
Member
|
Two of the changes (those containing "apt") are Debian specific. In non-Debian distros apt does not exist,
so this should be distro-neutral or state that these are a shortcut for use in Debian and indicate how to
do the same things generally
|
vkareh
requested changes
Feb 13, 2026
Comment on lines
+34
to
+35
| * apt build-dep -y atril | ||
| * apt install -y mate-common yelp-tools |
Member
There was a problem hiding this comment.
This is Debian-specific. I would just list what the general dependencies are without listing a specific command. Alternatively you can have sections for Debian-based distros, RPM-based distros, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makes it easier to compile by adding apt build-dep to install all necessary dependencies atril needs.