Test speakers#217
Conversation
There was a problem hiding this comment.
On my setup (HDMI sound from AMD video card over DP available but does not actually work, analog outputs from motherboard work), this had the effect of forcing the tested speakers to always be those chosen in the "output" tab, ignoring the device chosen in the "hardware" tab. This comes from effectively being able to set the chosen device in two different places, and the fact that these two settings can differ.
Might be better if these two were linked together between those tabs in the GUI, so the last device selected in either tab would always be the one actually used-or if the "Hardware" tab were renamed "Test Hardware" and also used only the device selected within itself.
We DO need to unbreak currently broken speaker tests so this might be better than the current defaults but I suspect it as it stands now we'd get confusion and bug reports over it
|
The fix is somewhat simplistic but the only thing I can muster. Considering Test Speaker is broken I think this is better |
|
OK, I will let the rest of the team decide what to do. We replace a major bug with a lesser one as this stands, I will let the others on the team weigh in on this. |
Well, I was asked to create a PR with these if you look at the issue tracker long time ago. It is a bit late to |
|
Not my call to do this solo, so called for other reviews. |
|
Been a year now |
|
The mono test code looks OK (not tested). The stream selection looks wrong. I don't quite understand the exact issue, and possibly I don't have hardware to test it (I don't have any HDMI devices to plug for example), but I'm willing to see what I can do if I get more info on options to reproduce the issue. |
if the choosen output isn't wanted/faulty you don't get any sound or wrong output choosen. |
|
Also, have you noticed that the Input/Output devices windows is too small when having many choices? |
|
Tested by rebuilding Debian 1.26 source package... but with or without this PR, test buttons do nothing (no sound). |
|
BT HFP/HSP could really use the Mono test fix. |
In that case, can you remove the stream selection changes in this PR? |
I am afraid not, that PR context is lost. Just cherry-pick what you want. |
Make Mono speker produce proper test adio instead of pink noise
vkareh
force-pushed
the
test-speakers
branch
2 times, most recently
from
1dfa9f9 to
d6c0048
Compare
|
Perfect, I just dropped the stream selection commit and kept the mono test fix. |
5 participants
No description provided.