Move press() call from mousedown to mouseup. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Nov 12, 2025
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
One typo and one suggestion for the comment.
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either expressor implied. |
Member
There was a problem hiding this comment.
Suggested change
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either expressor implied. | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| } | ||
|
|
||
| /** | ||
| * Do the press on mouseup so menu gets the mouse up rather than a dialog box |
Member
There was a problem hiding this comment.
Suggested change
| * Do the press on mouseup so menu gets the mouse up rather than a dialog box | |
| * Perform press on mouseup so menu gets the mouse up rather than a dialog box |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes command-based menu items to process the
press()method on mouse up rather than mouse down, so that the mouseup event ge4ts processed by the menu rather than being passed on to whatever is behind the menu. That is important, for example, when a dialog is opened, so that the mouse doesn't cancel the dialog.This also means you can click on a menu item and then move off the menu item to prevent its action from being taken, as with most os system menus.