Add a maximum feed size #906
Open
+233
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadzik
requested changes
Apr 4, 2024
tests/FeedReader.spec.ts
Outdated
| const items = await storage.hasSeenFeedGuids(feedUrl, ...expectedHash); | ||
| expect(items).to.deep.equal(expectedHash); | ||
| }); | ||
| it.only("should fail to handle a feed which exceed the maximum size.", async () => { |
There was a problem hiding this comment.
Focused test!
We could probably use the "no focused tests" eslint rule.
tests/FeedReader.spec.ts
Outdated
| it.only("should fail to handle a feed which exceed the maximum size.", async () => { | ||
| const { feedReader, feedUrl } = await constructFeedReader(() => ({ | ||
| headers: { | ||
| 'Content-Length': Math.pow(1024, 2).toString(), |
There was a problem hiding this comment.
Hm, isn't this exactly 1 megabyte? This should not be failing.
tadzik
approved these changes
May 16, 2024
| }, | ||
| Ok(body) => { | ||
| // Check if we only got the length after loading the response. | ||
| match body.len() as u64 <= max_content_size { |
There was a problem hiding this comment.
Minor: I'd just write it as if body.len() as u64 <= max_content_size {..., since if is also an expression in Rust. match kinda makes it seems like there's more to it than that.
| <guid isPermaLink="true">http://www.example.com/blog/post/${i}</guid> | ||
| </item>`).join('')} | ||
| </channel> | ||
| </rss>`; |
There was a problem hiding this comment.
Note: this is fine, measuring at 1.2 MB. If we wanted to be extra careful, we could do an assert checking if it's longer than 1024*1024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents massive feeds from potentially clogging up Hookshot. Some RSS/ATOM feeds are horribly maintained and just list every entry ever, so we've set a "sensible limit" of 25MB.