Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle RSA token handling in Rust #915

Merged
merged 37 commits into from
Apr 8, 2024
Merged

Handle RSA token handling in Rust #915

merged 37 commits into from
Apr 8, 2024

Conversation

Half-Shot
Copy link
Contributor

As part of the work to move to EC25519 (#912), I want to move us away from using Node for crypto handling here. This moves the token handling parts into Rust which hopefully gives us a little speed boost.

Half-Shot and others added 23 commits February 26, 2024 10:28
@Half-Shot
Split out queue and cache config
c2e8f0e
@Half-Shot
Update usages of cache config,
28684eb
@Half-Shot
Update default
0bdfb98
@Half-Shot
Cleanup
9dc9c3c
@Half-Shot
Make queue optional.
869e35c
@Half-Shot
config updates.
265431d
@Half-Shot
changelog
939d09e
@Half-Shot
update spec config
4fc89d2
@Half-Shot
Update tests
35a9cd0
@Half-Shot
tweak import
9f53c2c
@Half-Shot
Update default config.
b912c52
@Half-Shot
fixup test
5e97fa2
@Half-Shot @AndrewFerr
Update config.sample.yml
3d7f395 
Co-authored-by: Andrew Ferrazzutti <[email protected]>
Signed-off-by: Will Hunt <[email protected]>
@Half-Shot
Update encryption.md
6740a96 
Signed-off-by: Will Hunt <[email protected]>
@Half-Shot
Clear up worker config
c2809bb 
Signed-off-by: Will Hunt <[email protected]>
@Half-Shot @AndrewFerr
Update src/config/Config.ts
5baacd5 
Co-authored-by: Andrew Ferrazzutti <[email protected]>
Signed-off-by: Will Hunt <[email protected]>
@Half-Shot
update helm config
79d36b2
@Half-Shot
move UserTokenStore.ts
aded8bf
@Half-Shot
Port all the imports to new path.
ea57a49
@Half-Shot
Port RSA handling to rust.
d2a5d24
@Half-Shot
Add tests.
5f03a84
@Half-Shot
linting
06ab650
@Half-Shot
lint rust
1e9ef23
Base automatically changed from hs/simplify-cache-config to main March 19, 2024 16:45
@Half-Shot Half-Shot changed the base branch from main to hs/jira-manifest-support March 19, 2024 17:26
@Half-Shot Half-Shot changed the base branch from hs/jira-manifest-support to main March 19, 2024 17:27
@Half-Shot Half-Shot marked this pull request as ready for review March 20, 2024 10:58
@Half-Shot Half-Shot requested a review from a team as a code owner March 20, 2024 10:58
tadzik
tadzik approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks – looks good!

src/tokens/mod.rs Outdated Show resolved Hide resolved
@Half-Shot Half-Shot merged commit 6482c7e into main Apr 8, 2024
16 checks passed
@Half-Shot Half-Shot deleted the hs/multi-hash branch April 8, 2024 14:22
@Half-Shot Half-Shot mentioned this pull request Apr 16, 2024
Closed
Half-Shot added a commit that referenced this pull request Apr 16, 2024
@Half-Shot
Revert "Handle RSA token handling in Rust (#915)"
49b9483 
This reverts commit 6482c7e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @tadzik