Skip to content

Support for MSC4388 for the QR login#6173

Draft
poljar wants to merge 19 commits intomainfrom
poljar/qr-login/msc4388
Draft

Support for MSC4388 for the QR login#6173
poljar wants to merge 19 commits intomainfrom
poljar/qr-login/msc4388

Conversation

@poljar
Copy link
Contributor

@poljar poljar commented Feb 13, 2026

  • Public API changes documented in changelogs (optional)

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 95.61243% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.90%. Comparing base (7beda79) to head (cb359ee).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...cation/oauth/qrcode/rendezvous_channel/msc_4388.rs 95.79% 11 Missing and 2 partials ⚠️
...atrix-sdk/src/authentication/oauth/qrcode/login.rs 95.77% 10 Missing and 2 partials ⚠️
...tion/oauth/qrcode/secure_channel/crypto_channel.rs 67.85% 0 Missing and 9 partials ⚠️
.../authentication/oauth/qrcode/secure_channel/mod.rs 94.70% 4 Missing and 4 partials ⚠️
...hentication/oauth/qrcode/rendezvous_channel/mod.rs 89.47% 0 Missing and 4 partials ⚠️
...atrix-sdk/src/authentication/oauth/qrcode/grant.rs 98.55% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6173      +/-   ##
==========================================
+ Coverage   89.81%   89.90%   +0.09%     
==========================================
  Files         376      377       +1     
  Lines      102614   103507     +893     
  Branches   102614   103507     +893     
==========================================
+ Hits        92163    93063     +900     
+ Misses       6871     6854      -17     
- Partials     3580     3590      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing poljar/qr-login/msc4388 (cb359ee) with main (7beda79)

Open in CodSpeed

@poljar poljar force-pushed the poljar/qr-login/msc4388 branch from e50a48d to 2379010 Compare February 16, 2026 08:58
@poljar poljar force-pushed the poljar/qr-login/msc4388 branch 2 times, most recently from fb95097 to 5849fcc Compare February 25, 2026 11:20
@poljar poljar force-pushed the poljar/qr-login/msc4388 branch 4 times, most recently from fc70d24 to 036dd95 Compare March 18, 2026 13:08
} else {
QrAuthMessage::LoginProtocols(LoginProtocolsMessage::Msc4108 {
protocols: vec![LoginProtocolType::DeviceAuthorizationGrant],
homeserver: self.client.homeserver(),
Copy link
Member

@hughns hughns Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// n.b. this doesn't match the MSC which says that it is a server name not the base URL
// Should be something like self.client.user_id_server_name()

@poljar poljar force-pushed the poljar/qr-login/msc4388 branch from 5b449d8 to aa5baf9 Compare March 20, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants