Draft
Conversation
Contributor
poljar
commented
Feb 13, 2026
- Public API changes documented in changelogs (optional)
12 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6173 +/- ##
==========================================
+ Coverage 89.81% 89.90% +0.09%
==========================================
Files 376 377 +1
Lines 102614 103507 +893
Branches 102614 103507 +893
==========================================
+ Hits 92163 93063 +900
+ Misses 6871 6854 -17
- Partials 3580 3590 +10 ☔ View full report in Codecov by Sentry. |
e50a48d to
2379010
Compare
fb95097 to
5849fcc
Compare
fc70d24 to
036dd95
Compare
hughns
reviewed
Mar 18, 2026
hughns
reviewed
Mar 20, 2026
hughns
reviewed
Mar 20, 2026
| } else { | ||
| QrAuthMessage::LoginProtocols(LoginProtocolsMessage::Msc4108 { | ||
| protocols: vec![LoginProtocolType::DeviceAuthorizationGrant], | ||
| homeserver: self.client.homeserver(), |
Member
There was a problem hiding this comment.
// n.b. this doesn't match the MSC which says that it is a server name not the base URL
// Should be something like self.client.user_id_server_name()
This patch connects everything together, the new QR code data format, secure channel, and rendezvous channel together to work for the QR login.
…style QR login
…ot support the new one
5b449d8 to
aa5baf9
Compare
… qr login messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.