Skip to content

added fields for clients to use for alternate links for android and ios along with new SVGs for both #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zodiepupper
Copy link

@zodiepupper zodiepupper commented Apr 15, 2025

added fields for clients to use for alternate links for android and ios along with new SVGs for both

i was adding my matrix client to client list and found no way to add platform-independent links for where to download the client.

like for android the only options were google play and fdroid

this just extends the other_linux_link idea to include other_android_link and other_ios_link

Signed-off-by: Zodie Woolsey [email protected]

Copy link
Collaborator

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! The code looks good and works. The buttons look good to me, too, thanks for going the extra mile for that!

Sadly something iffy about the buttons or use of logos and text marks therein is about their licensing. Sorry, I only realised this after requesting this feature or I would have mentioned it. Could you tell us the sources for the pieces used, and if you happen to know them, the licenses? Then we can figure out how we can proceed there :)

@HarHarLinks HarHarLinks added enhancement This would be an improvement to the website. ecosystem Adding and removing ecosystem projects labels Apr 16, 2025
@zodiepupper
Copy link
Author

Thank you for this contribution! The code looks good and works. The buttons look good to me, too, thanks for going the extra mile for that!

Sadly something iffy about the buttons or use of logos and text marks therein is about their licensing. Sorry, I only realised this after requesting this feature or I would have mentioned it. Could you tell us the sources for the pieces used, and if you happen to know them, the licenses? Then we can figure out how we can proceed there :)

the android assets are from here:
https://developer.android.com/distribute/marketing-tools/brand-guidelines
the source of the iOS icon asset was from the app store badge that was already present in the repo at:
https://github.com/matrix-org/matrix.org/blob/main/static/assets/stores/app_store.svg

lemme know if i should recreate the button graphics.

@zodiepupper zodiepupper force-pushed the add_alt_links_ios_android branch from 8698a35 to 349f897 Compare April 17, 2025 15:28
@zodiepupper
Copy link
Author

ok, i pulled your suggested change and squashed the commits to keep it at only 1 commit since it's such a small feature change. lemme know if there is anything else you would like me to do here.

^-^

@zodiepupper zodiepupper requested a review from HarHarLinks April 17, 2025 20:47
@zodiepupper zodiepupper force-pushed the add_alt_links_ios_android branch from 349f897 to b1144ba Compare April 17, 2025 20:51
@zodiepupper zodiepupper force-pushed the add_alt_links_ios_android branch from b1144ba to 52d2c7a Compare April 17, 2025 20:52
@zodiepupper
Copy link
Author

realized i didn't add these fields to the docs so i added them and i also added the other_linux_link option in the docs so it's more obvious that it exists.

@zodiepupper
Copy link
Author

is there anything else i should do to get this merged? i think am satisfied with my changes at this point.

@HarHarLinks
Copy link
Collaborator

Sorry for letting you wait so long, the website maintainers are stuck on figuring out how to proceed: #2694

@zodiepupper
Copy link
Author

zodiepupper commented May 4, 2025

i don't think they conflict, right? the other PR is for showing the linux download button, but mine is just for mobile. i can revert any of my changes that conflict, if that makes it easier

edit: nevermind, i misunderstood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem Adding and removing ecosystem projects enhancement This would be an improvement to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants