-
Notifications
You must be signed in to change notification settings - Fork 370
added fields for clients to use for alternate links for android and ios along with new SVGs for both #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution! The code looks good and works. The buttons look good to me, too, thanks for going the extra mile for that!
Sadly something iffy about the buttons or use of logos and text marks therein is about their licensing. Sorry, I only realised this after requesting this feature or I would have mentioned it. Could you tell us the sources for the pieces used, and if you happen to know them, the licenses? Then we can figure out how we can proceed there :)
the android assets are from here: lemme know if i should recreate the button graphics. |
8698a35
to
349f897
Compare
ok, i pulled your suggested change and squashed the commits to keep it at only 1 commit since it's such a small feature change. lemme know if there is anything else you would like me to do here. ^-^ |
349f897
to
b1144ba
Compare
…os along with new SVGs for both
b1144ba
to
52d2c7a
Compare
realized i didn't add these fields to the docs so i added them and i also added the |
is there anything else i should do to get this merged? i think am satisfied with my changes at this point. |
Sorry for letting you wait so long, the website maintainers are stuck on figuring out how to proceed: #2694 |
i don't think they conflict, right? the other PR is for showing the linux download button, but mine is just for mobile. i can revert any of my changes that conflict, if that makes it easier edit: nevermind, i misunderstood |
added fields for clients to use for alternate links for android and ios along with new SVGs for both
i was adding my matrix client to client list and found no way to add platform-independent links for where to download the client.
like for android the only options were google play and fdroid
this just extends the
other_linux_link
idea to includeother_android_link
andother_ios_link
Signed-off-by: Zodie Woolsey [email protected]