Release v0.10.1: Various improvements#95
Conversation
- Updated renderer implementations - Improved styling and visual effects - Updated dependencies and configuration
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| #[allow(clippy::missing_errors_doc)] | ||
| fn new(title: Option<String>, progress: Progress) -> Self; | ||
|
|
||
| #[must_use] | ||
| fn render<W: Write>(&self, w: &mut W) -> Result<u16> { | ||
| let row = self.render_content(w); | ||
| queue!(w, Clear(ClearType::FromCursorDown))?; | ||
| row | ||
| } | ||
|
|
||
| #[must_use] | ||
| #[allow(clippy::missing_errors_doc)] |
There was a problem hiding this comment.
[P1] Avoid breaking StyledRenderer API in a patch release
The patch bumps the crate from 0.10.0 to 0.10.1 but also renames the required trait method from render to render_content while providing a new default render implementation. StyledRenderer is publicly re‑exported, so any downstream crate that implemented the trait will fail to compile after this release because their impls still define render and the trait now requires render_content. Introducing an API‑breaking change in a patch release violates SemVer expectations. Either keep render as the required method (adding render_content as a helper) or bump the minor/major version to signal the breaking change.
Useful? React with 👍 / 👎.
1 participant
Release v0.10.1
This release includes various improvements and enhancements:
Changes
Files Modified
Testing
This is ready for review and merge into main.