Adding typescript to the project#401
Open
linspw wants to merge 2 commits intomauricius:mainfrom
Open
Conversation
linspw
commented
Jan 29, 2024
| { | ||
| "name": "vue-draggable-resizable", | ||
| "version": "3.0.0-beta.2", | ||
| "version": "3.0.0", |
linspw
commented
Jan 29, 2024
| parseInt(rect.width), | ||
| parseInt(rect.height) | ||
| // @ts-ignore | ||
| parseInt(rect.width, 10), |
linspw
commented
Jan 29, 2024
Comment on lines
+326
to
+348
| bounds: { | ||
| minLeft: null, | ||
| maxLeft: null, | ||
| minRight: null, | ||
| maxRight: null, | ||
| minTop: null, | ||
| maxTop: null, | ||
| minBottom: null, | ||
| maxBottom: null, | ||
| }, | ||
|
|
||
| mouseClickPosition: { | ||
| mouseX: 0, | ||
| mouseY: 0, | ||
| x: 0, | ||
| y: 0, | ||
| w: 0, | ||
| h: 0, | ||
| left: 0, | ||
| bottom: 0, | ||
| top: 0, | ||
| right: 0, | ||
| }, |
linspw
commented
Jan 29, 2024
|
|
||
| let eventsFor = events.mouse; | ||
|
|
||
| interface State { |
linspw
commented
Feb 5, 2024
Comment on lines
-29
to
-30
| parseFloat(style.getPropertyValue('width'), 10), | ||
| parseFloat(style.getPropertyValue('height'), 10) |
Author
|
Do you think @mauricius that PR makes sense? |
|
@mauricius it would be great to add TS support to the project! |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everything is fine?
I would like to thank you for the library, it is fantastic!
My suggestion with this PR is to contribute to improving the typing in the project
I thank the attention
This closes:
#294
OBS:
[X] All tests passed
[X] Build process working fine
[X] Exporting types
Type autocomplete
