Resizing should not fire before activated#61
Open
cyberj wants to merge 1 commit into
Open
Conversation
Owner
|
You're right. The Also take a look to this issue. It might help you with your use case. Thanks |
Author
|
Thanks for this issue, that will solve my problem. 👍
Should I remove it anyway and change the unit tests accordingly ? |
Owner
|
Sorry for the delay. Yes feel free to change the tests, as long as existing functionalities keep working. In my opinion the event should fire only if the component is actually dragged or resized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually when you click (without moving) on a disabled component the
resizingevent is fired beforeactivatedProblem is, I have multiple resizable components in a v-for loop, and I want to know which one will be resized/dragged.
If I try :
@resizing="onResize(index, $event)my method will only get the first$emitparameter (integer forleftpos)So I try my luck by passing the index to
@activatedto set an index (likethis.elselected) but he is called after the resizing event.This PR suppress any resizing event happening before the activated event