Skip to content

Document Tag removal confirmation and expandable Tags tile on Contact detail page - #779

Merged
adiati98 merged 7 commits into
mautic:7.2from
Promptless:promptless/tag-removal-confirmation-7.2
Jul 27, 2026
Merged

Document Tag removal confirmation and expandable Tags tile on Contact detail page#779
adiati98 merged 7 commits into
mautic:7.2from
Promptless:promptless/tag-removal-confirmation-7.2

Conversation

@promptless-for-oss

@promptless-for-oss promptless-for-oss commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Adds a "Viewing and removing Tags on a Contact" section to tags.rst describing the Tag removal confirmation dialog and the expandable Tags tile (first 8 Tags shown when a Contact has more than 8). Based on merged mautic/mautic PR #15845.

Latest revision — addressing @adiati98's Vale review

After the earlier .. vale off / .. vale on wrapper was cleaned up, three Mautic.FeatureList suggestions resurfaced on the two body paragraphs. These are all false positives, so this revision silences only the Mautic.FeatureList rule across those two paragraphs using per-rule directives (.. vale Mautic.FeatureList = NO / .. vale Mautic.FeatureList = YES) rather than a blanket .. vale off/on block. The prose is unchanged, and no other Vale rule is suppressed. A local Vale run on the file now reports 0 errors, 0 warnings, and 0 suggestions.

Per-comment disposition:

  • page in "the Contact's detail page" (both occurrences) — kept as-is. "detail page" is the established term for a Contact's main record view elsewhere in these docs (for example contacts/manage_contacts.rst and contacts/frequency_rules.rst); it is not the Mautic Landing Page feature, so rewording to "Landing Page" would be incorrect and inconsistent. Resolved by scoping the rule off for these paragraphs.
  • contact in 'Are you sure you want to remove this tag from the contact?' — kept as-is. This is the verbatim UI confirmation string Mautic displays, and the style guide requires UI strings to be reproduced exactly in single quotes, so it can't be capitalized. Resolved by the same scoped rule window.

Comment thread docs/contacts/tags.rst
Comment thread docs/contacts/tags.rst
Comment thread docs/contacts/tags.rst
@adiati98
adiati98 requested a review from escopecz July 15, 2026 04:56
…f/on

Per @adiati98 review on PR mautic#779, the section heading is now Vale-checked
normally and the two body paragraphs are wrapped in .. vale off / .. vale on.
Comment thread docs/contacts/tags.rst
Per @adiati98's follow-up review on PR mautic#779, the 'Viewing and removing
Tags on a Contact' heading is now wrapped in its own .. vale off /
.. vale on block, and the body paragraphs remain in a separate block.
Vale passes clean.
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98 — both review comments are addressed and the branch has been updated.

The Vale markup on the "Viewing and removing Tags on a Contact" section is now restructured so it's consistent with the rest of the file:

  • The section heading is wrapped in its own .. vale off / .. vale on block.
  • The two body paragraphs (the Tags tile / expandable behavior and the Tag removal confirmation dialog) are wrapped in a separate .. vale off / .. vale on block.

Vale now runs clean on docs/contacts/tags.rst (0 errors, 0 warnings, 0 suggestions) — including the earlier Google.Headings sentence-case warning, which the heading wrapper resolves.

@escopecz

Copy link
Copy Markdown
Member

@shinde-rahul please review this.

@escopecz
escopecz removed their request for review July 15, 2026 07:50
Removed unnecessary vale directives from tags documentation.

@shinde-rahul shinde-rahul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation aligns with the implementation.

shinde-rahul
shinde-rahul previously approved these changes Jul 22, 2026

@shinde-rahul shinde-rahul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions.

Comment thread docs/contacts/tags.rst
Comment thread docs/contacts/tags.rst
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks — we're addressing the flagged Vale warnings on this PR now and will push the update shortly.

…hits

Narrowly disable only Mautic.FeatureList around the two body paragraphs
of the 'Viewing and removing Tags on a Contact' section. The 'page' hits
('Contact's detail page' is the house term, not the Landing Page feature)
and the 'contact' hit (inside the verbatim UI confirmation string) are
false positives. Uses per-rule directives instead of a blanket vale
off/on wrapper, and leaves prose byte-for-byte unchanged.
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98 — all three Vale Mautic.FeatureList findings are resolved.

On investigation they were false positives:

  • 'page' in "the Contact's detail page" (2×) refers to a Contact's record view — the house term used across the docs (manage_contacts.rst, frequency_rules.rst) — not the Landing Page feature.
  • The lowercase 'contact' is inside the verbatim UI confirmation string 'Are you sure you want to remove this tag from the contact?', which the style guide requires us to quote exactly.

Rather than reword either, I narrowly disabled just the Mautic.FeatureList rule around those two paragraphs with per-rule .. vale Mautic.FeatureList = NO/YES directives — no blanket vale off, no prose change. A local Vale run is now clean (0/0/0), and the PR description records the per-comment reasoning. Ready for another look.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/aside

Thanks for the review, @shinde-rahul! 🚀

@adiati98
adiati98 merged commit 2f2888f into mautic:7.2 Jul 27, 2026
3 checks passed
@promptless-for-oss
promptless-for-oss deleted the promptless/tag-removal-confirmation-7.2 branch July 27, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants