Document Tag removal confirmation and expandable Tags tile on Contact detail page - #779
Conversation
…f/on Per @adiati98 review on PR mautic#779, the section heading is now Vale-checked normally and the two body paragraphs are wrapped in .. vale off / .. vale on.
Per @adiati98's follow-up review on PR mautic#779, the 'Viewing and removing Tags on a Contact' heading is now wrapped in its own .. vale off / .. vale on block, and the body paragraphs remain in a separate block. Vale passes clean.
|
Thanks @adiati98 — both review comments are addressed and the branch has been updated. The Vale markup on the "Viewing and removing Tags on a Contact" section is now restructured so it's consistent with the rest of the file:
Vale now runs clean on |
|
@shinde-rahul please review this. |
Removed unnecessary vale directives from tags documentation.
shinde-rahul
left a comment
There was a problem hiding this comment.
The documentation aligns with the implementation.
shinde-rahul
left a comment
There was a problem hiding this comment.
Approved from my side.
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
|
Thanks — we're addressing the flagged Vale warnings on this PR now and will push the update shortly. |
…hits
Narrowly disable only Mautic.FeatureList around the two body paragraphs
of the 'Viewing and removing Tags on a Contact' section. The 'page' hits
('Contact's detail page' is the house term, not the Landing Page feature)
and the 'contact' hit (inside the verbatim UI confirmation string) are
false positives. Uses per-rule directives instead of a blanket vale
off/on wrapper, and leaves prose byte-for-byte unchanged.
|
Thanks @adiati98 — all three Vale On investigation they were false positives:
Rather than reword either, I narrowly disabled just the |
adiati98
left a comment
There was a problem hiding this comment.
/aside
Thanks for the review, @shinde-rahul! 🚀
Adds a "Viewing and removing Tags on a Contact" section to
tags.rstdescribing the Tag removal confirmation dialog and the expandable Tags tile (first 8 Tags shown when a Contact has more than 8). Based on merged mautic/mautic PR #15845.Latest revision — addressing @adiati98's Vale review
After the earlier
.. vale off / .. vale onwrapper was cleaned up, threeMautic.FeatureListsuggestions resurfaced on the two body paragraphs. These are all false positives, so this revision silences only theMautic.FeatureListrule across those two paragraphs using per-rule directives (.. vale Mautic.FeatureList = NO/.. vale Mautic.FeatureList = YES) rather than a blanket.. vale off/onblock. The prose is unchanged, and no other Vale rule is suppressed. A local Vale run on the file now reports 0 errors, 0 warnings, and 0 suggestions.Per-comment disposition:
pagein "the Contact's detail page" (both occurrences) — kept as-is. "detail page" is the established term for a Contact's main record view elsewhere in these docs (for examplecontacts/manage_contacts.rstandcontacts/frequency_rules.rst); it is not the Mautic Landing Page feature, so rewording to "Landing Page" would be incorrect and inconsistent. Resolved by scoping the rule off for these paragraphs.contactin 'Are you sure you want to remove this tag from the contact?' — kept as-is. This is the verbatim UI confirmation string Mautic displays, and the style guide requires UI strings to be reproduced exactly in single quotes, so it can't be capitalized. Resolved by the same scoped rule window.