windows installer: handle missing uninstaller

[AlexKlimaj]

Attempt at fixing #13615

[Copilot]

Pull Request Overview

This PR addresses issue #13615 by adding logic to handle cases where the Windows uninstaller executable is missing despite registry entries still existing. The installer now checks if the uninstaller file exists before attempting to run it, and cleans up orphaned registry keys if the file is not found.

Key Changes:

• Added checkUninstaller section to verify uninstaller file existence before execution
• Implemented quote removal logic to extract the file path from the UninstallString registry value
• Added cleanupOrphanedRegistry section to delete orphaned registry keys when uninstaller is missing

[Copilot]

The quote removal logic assumes the UninstallString always has quotes, but doesn't verify this assumption. If the registry value lacks quotes (e.g., from a corrupted registry or different installer version), this code will incorrectly trim the first and last characters of the actual path.

Consider using a defensive approach that checks for quotes before removing them:

StrCpy $R1 $R0 1       ; Get first character
StrCmp $R1 '"' +1 +4   ; If it's a quote, remove quotes
StrCpy $R1 $R0 "" 1    ; Skip first quote
StrLen $R2 $R1
IntOp $R2 $R2 - 1      ; Remove last quote
StrCpy $R1 $R1 $R2
Goto +2
StrCpy $R1 $R0         ; No quotes, use path as-is

Suggested change

	StrCpy $R1 $R0 "" 1 ; Skip first quote
	StrLen $R2 $R1
	IntOp $R2 $R2 - 1 ; Remove last quote
	StrCpy $R1 $R1 $R2
	StrCpy $R1 $R0 1 ; Get first character
	StrCmp $R1 '"' +1 +4 ; If it's a quote, remove quotes
	StrCpy $R1 $R0 "" 1 ; Skip first quote
	StrLen $R2 $R1
	IntOp $R2 $R2 - 1 ; Remove last quote
	StrCpy $R1 $R1 $R2
	Goto +2
	StrCpy $R1 $R0 ; No quotes, use path as-is

[Copilot]

[nitpick] The SetRegView 64 call is redundant here as it was already set at line 64 before reading the registry. This line can be removed to avoid unnecessary duplication.

Suggested change

SetRegView 64

[HTRamsey]

Did this end up working out?

[AlexKlimaj]

I do notice that the daily no longer checks for the 32 bit uninstaller.

This PR

Release

Daily with release installed with uninstaller renamed

This PR with uninstaller renamed