Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#296] Avoid breaking items relations to zaken #300

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm commented Aug 22, 2024

Fixes #296
Fixes #309

@SilviaAmAm SilviaAmAm marked this pull request as draft August 22, 2024 09:25
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.71%. Comparing base (1136374) to head (9dd8dd1).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   77.54%   77.71%   +0.17%     
==========================================
  Files         220      223       +3     
  Lines        6827     6951     +124     
  Branches      133      132       -1     
==========================================
+ Hits         5294     5402     +108     
- Misses       1409     1426      +17     
+ Partials      124      123       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm marked this pull request as ready for review August 22, 2024 12:55
@SilviaAmAm SilviaAmAm marked this pull request as draft August 28, 2024 08:22
@SilviaAmAm
Copy link
Collaborator Author

With the issue about changing how we cache zaken, this may no longer be needed (#309). I need to think about it.

@SilviaAmAm SilviaAmAm removed the request for review from svenvandescheur August 28, 2024 08:24
@SilviaAmAm SilviaAmAm force-pushed the fix/296-avoid-breaking-relations branch from 27b2cfc to 67a3202 Compare September 3, 2024 12:44
@SilviaAmAm SilviaAmAm force-pushed the fix/296-avoid-breaking-relations branch from 67a3202 to 3ef5a09 Compare September 3, 2024 12:48
@SilviaAmAm SilviaAmAm force-pushed the fix/296-avoid-breaking-relations branch from 3ef5a09 to 9dd8dd1 Compare September 3, 2024 12:57
@SilviaAmAm
Copy link
Collaborator Author

Decided: still needed for the resync process.

@SilviaAmAm SilviaAmAm marked this pull request as ready for review September 3, 2024 13:03
@svenvandescheur svenvandescheur merged commit e08aa19 into main Sep 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants