[#377] Fix review responses #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
+ Coverage 76.94% 77.17% +0.22%
==========================================
Files 240 243 +3
Lines 7504 7578 +74
Branches 158 158
==========================================
+ Hits 5774 5848 +74
Misses 1583 1583
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SilviaAmAm
force-pushed
the
fix/377-fix-review-responses
branch
from
07af777 to
626aa35
Compare
SilviaAmAm
commented
Sep 24, 2024
There was a problem hiding this comment.
Refactored: moved to backend/src/openarchiefbeheer/destruction/tests/endpoints/test_reviewresponse.py
SilviaAmAm
force-pushed
the
fix/377-fix-review-responses
branch
from
3ed8fc2 to
2fb0fcd
Compare
Xaohs
requested changes
Sep 26, 2024
frontend/src/pages/destructionlist/detail/DestructionListDetail.tsx
Outdated
Show resolved
Hide resolved
Now we check that an item that is being kept in a list cannot be changed. We also check that when extending the bewaartermijn, the selectielijstklasse cannot be updated
SilviaAmAm
force-pushed
the
fix/377-fix-review-responses
branch
from
2fb0fcd to
3ec6429
Compare
Xaohs
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #377