Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#728] - feat: dialog logo #742

Merged
merged 4 commits into from
Mar 13, 2025
Merged

✨ [#728] - feat: dialog logo #742

merged 4 commits into from
Mar 13, 2025

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Mar 11, 2025

partly closes #728

Contents of dropdown will be updated whenever backend is done (structuring depending on the data we get)

  • Implements a re-usable "Logo" component that simply is the image of the OAB logo
  • Expansion on Logo that implements Logo as a Dropdown component to be used in the Toolbar

@Xaohs Xaohs requested a review from svenvandescheur March 11, 2025 12:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.02%. Comparing base (558cc1a) to head (c442b04).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/components/Logo/Logo.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   90.04%   90.02%   -0.02%     
==========================================
  Files         208      208              
  Lines        6406     6426      +20     
  Branches      704      703       -1     
==========================================
+ Hits         5768     5785      +17     
- Misses        638      641       +3     
Flag Coverage Δ
backend 91.02% <ø> (ø)
jest 34.50% <0.00%> (-0.13%) ⬇️
storybook 85.61% <87.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Xaohs Xaohs force-pushed the issue/#728-logo-dialog branch from d814f13 to a4c980b Compare March 11, 2025 12:39
@Xaohs Xaohs marked this pull request as ready for review March 11, 2025 12:40
@Xaohs Xaohs requested a review from svenvandescheur March 11, 2025 14:44
@Xaohs Xaohs merged commit 276c8cc into main Mar 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versienummer inzichtelijk maken
3 participants