[#3087] Add DB constraint that primary and alternative phonenumber differ #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
issue/3087-email-validation
branch
from
8a4b381 to
53e7a37
Compare
swrichards
reviewed
Mar 12, 2025
...ounts/migrations/0081_user_check_alternative_phonenumber_differs_from_primary_phonenumber.py
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1662 +/- ##
========================================
Coverage 94.13% 94.14%
========================================
Files 1088 1090 +2
Lines 40150 40186 +36
========================================
+ Hits 37797 37832 +35
- Misses 2353 2354 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pi-sigma
force-pushed
the
issue/3087-email-validation
branch
from
53e7a37 to
896d1ee
Compare
swrichards
requested changes
Mar 12, 2025
| @@ -194,6 +194,10 @@ def clean_phonenumber_alternative(self): | |||
| "A primary phone number is required for setting an alternative phone number" | |||
| ) | |||
| ) | |||
| if phonenumber_alt and phonenumber_alt == phonenumber: | |||
| raise ValidationError( | |||
| _("Primary adn secondary phone numbers cannot be the same") | |||
There was a problem hiding this comment.
Suggested change
| _("Primary adn secondary phone numbers cannot be the same") | |
| _("Primary and secondary phone numbers cannot be the same") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/3087