Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3076] page title change with cms page title #1665

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

linssen814
Copy link
Contributor

@linssen814 linssen814 commented Mar 11, 2025

Made it so that the browser tab title as well as the header of the 'Benefits', 'Collaboration' and 'Mijn Vragen' pages change with the page title configured in the cms.

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/us/3076

Note that for the 'Mijn Vragen' page, the way that the Page object is retrieved is kind of iffy, though it does seem to work. See the comment above it.

@linssen814 linssen814 force-pushed the fix/3076-page-title-changes-with-cms-page-title branch 4 times, most recently from 4eb11e3 to b6934e5 Compare March 12, 2025 14:56
@linssen814 linssen814 force-pushed the fix/3076-page-title-changes-with-cms-page-title branch from b6934e5 to 445a1e0 Compare March 12, 2025 15:26
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.13%. Comparing base (788a90a) to head (445a1e0).

Files with missing lines Patch % Lines
src/open_inwoner/accounts/views/contactmoments.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1665      +/-   ##
===========================================
- Coverage    94.13%   94.13%   -0.01%     
===========================================
  Files         1088     1088              
  Lines        40150    40158       +8     
===========================================
+ Hits         37797    37804       +7     
- Misses        2353     2354       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@linssen814 linssen814 requested a review from pi-sigma March 12, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants