Skip to content

test: simplify test helpers - #70

Merged
mccutchen merged 3 commits into
mainfrom
test-helper-refactor
Oct 27, 2025
Merged

test: simplify test helpers#70
mccutchen merged 3 commits into
mainfrom
test-helper-refactor

Conversation

@mccutchen

Copy link
Copy Markdown
Owner

Simplify our internal assert package, now lightly adapted from this blog post. Primary benefits:

  • Unified assert.Equal() and assert.DeepEqual() implementation
  • Better assert.Error() implementation, which handles error types using errors.As()
  • Plus, just deleting a bunch of unused test helper code

@github-actions

github-actions Bot commented Oct 27, 2025

Copy link
Copy Markdown

🔥 Run benchmarks comparing d364a41 against main:

gh workflow run bench.yaml -f pr_number=70

Note: this comment will update with each new commit.

@codecov

codecov Bot commented Oct 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.11%. Comparing base (d008872) to head (d364a41).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files           2        2           
  Lines         425      425           
=======================================
  Hits          417      417           
  Misses          4        4           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mccutchen
mccutchen merged commit 91b0005 into main Oct 27, 2025
16 of 18 checks passed
@mccutchen
mccutchen deleted the test-helper-refactor branch October 27, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant