Skip to content

test: stop leaking goroutine - #74

Merged
mccutchen merged 2 commits into
mainfrom
goleak
Oct 28, 2025
Merged

test: stop leaking goroutine#74
mccutchen merged 2 commits into
mainfrom
goleak

Conversation

@mccutchen

Copy link
Copy Markdown
Owner

As part of investigating #72, I tried using uber-go/goleak to detect strangeness with goroutines. It turned up this one leak, but I doubt this is what's causing all of our problems.

@github-actions

github-actions Bot commented Oct 28, 2025

Copy link
Copy Markdown

🔥 Run benchmarks comparing 5be7a69 against main:

gh workflow run bench.yaml -f pr_number=74

Note: this comment will update with each new commit.

Comment thread websocket_test.go Outdated

resp, err := http.DefaultClient.Do(req)
assert.NilError(t, err)
defer resp.Body.Close()

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the leak, the other change is a drive-by cleanup of unnecessary code

@codecov

codecov Bot commented Oct 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (322a83a) to head (5be7a69).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files           2        2           
  Lines         421      421           
=======================================
  Hits          417      417           
  Misses          2        2           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mccutchen
mccutchen enabled auto-merge (squash) October 28, 2025 09:16
@mccutchen
mccutchen merged commit 351f4c6 into main Oct 28, 2025
15 of 16 checks passed
@mccutchen
mccutchen deleted the goleak branch October 28, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant