chore: refactor test suite to be all internal tests - #78
Merged
Conversation
|
🔥 Run benchmarks comparing d8082b7 against gh workflow run bench.yaml -f pr_number=78Note: this comment will update with each new commit. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 2 2
Lines 431 431
=======================================
Hits 427 427
Misses 2 2
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mccutchen
added a commit
that referenced
this pull request
Dec 5, 2025
A fast-follow on #78. The only reason our semi-complex `clientServerTest` mechanism passed both a `*Websocket` and a `net.Conn` into the test methods is because otherwise the websocket's underlying conn was inaccessible via the public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing almost entirely by the public API alone was a fun experiment, but it requires a few too many weird decisions (e.g. exposing the
BufferedConntype solely for the purposes of testing). Let's keep it simple.