-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Chrome 8 added speak CSS property
#27188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
queengooborg
wants to merge
4
commits into
mdn:main
Choose a base branch
from
queengooborg:css/properties/speak/chrome-corrections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−2
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're here: Safari added this property between 4.0.5 and 5.1.5 and removed it
in 12.111.1 (possibly renamed tospeak-as).Originally implemented via WebKit/WebKit@3b7c2c2 in WebKit 534.10 before Safari 5.1 (534.48).
Renamed via WebKit/WebKit@1f2d229 in WebKit 605.1.19 before Safari 11.1 (605.1.33).
This last change looks like it removed support for
speak, which supported these values:normal,none,spell-out,digits,literal-punctuation,no-punctuation.This explains why only the collector test for the
speakproperty passes in Safari 10.1 and Safari 11.1, but the tests for the values don't.So here's what I would suggest:
partial_implementationentry for Safari added 5.1 removed 11.1, pointing to thespeak-asproperty.css.properties.speak_aswithalternative_name: "speak".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the bug filed for Chrome about
speak, it sounds like it implementedspeakas an alternative name forspeak-as, just like what Safari used to do. Maybe what we should do is remove the data for thespeakproperty since WebKit only implemented it as an alias tospeak-as?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I fully understand. Are you suggesting to merge
speakdata intospeak-asdata?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct -- it's a strange scenario since the
speakproperty is its own property in the spec, but since no browser ever implementedspeakas anything but an alias forspeak-as...!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking at it again, I agree insofar as we should move the Chrome/Safari data over with
alternative_name, but maybe let's keep this feature for now, given that there is an impl_url for Firefox. For Chrome, we can use https://issues.chromium.org/issues/40813740 as the impl_url.