Skip to content

Update all browsers data for text-orientation CSS property #27189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update all browsers data for text-orientation CSS property #27189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions css/properties/text-orientation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "≤13.1"
"version_added": "10.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed from vertical-right via WebKit/WebKit@608ae58 in WebKit 602.1.10 before Safari 10 (602.1.50).

Suggested change
"version_added": "10.1"
"version_added": "10"

Let's add the vertical-right value, which was supported since the beginning, see WebKit/WebKit@87bbc48 in WebKit 534.24 before Safari 5.1 (534.48).

},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
Expand All @@ -94,7 +94,7 @@
},
{
"alternative_name": "sideways-right",
"version_added": "≤83"
"version_added": "25"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Chrome 25 used WebKit 537.22, I would expect this alternative name to also show up in Safari 7 (537.71).

Landed via WebKit/WebKit@57ac98a in WebKit 537.21, so it should also be in Safari 7.

Can we add it while we're here?

PS: Shouldn't we extract a separate subfeature for sideways-right? Based on WebKit/WebKit@b7bdc56, it was removed from the spec, so setting standard_track: true and deprecated: true should be the right thing to do.

}
],
"chrome_android": "mirror",
Expand All @@ -105,7 +105,7 @@
},
{
"alternative_name": "sideways-right",
"version_added": "≤72"
"version_added": "41"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1057329, sideways-right is already parsed since Firefox 35, so we could add a partial implementation since then.

Otherwise, Firefox 44 seems correct in terms of functionality: https://bugzilla.mozilla.org/show_bug.cgi?id=1193488

}
],
"firefox_android": "mirror",
Expand Down Expand Up @@ -147,7 +147,7 @@
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "≤13.1"
"version_added": "5.1"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
Expand Down