-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Chromium 138 size requirement changes for GPUBuffers mapped at creation #28210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Chromium 138 size requirement changes for GPUBuffers mapped at creation #28210
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, could we add subfeatures for the descriptor properties, and note this as part of the support data for size
?
/cc @Elchi3
Co-authored-by: Claas Augner <[email protected]>
I don't think that makes sense, in this case. The exception occurs on the method itself, and it is related to two different descriptor properties. |
I think it's rather common for behaviors to relate to multiple features, but you're right that it isn't associated much more to Before merging, I would like a second opinion from @Elchi3 or @ddbeck about this subfeature ( |
Honestly, I'm not sure this merits a subfeature. Reading about this, it seems to miss a few qualifiers for a feature:
This seems more fit for a note, something like "Before version 138, this method does not throw a |
Summary
In Chrome 138, the size requirements for
GPUBuffer
s mapped at creation have changed. During aGPUDevice.createBuffer()
call, ifmappedAtCreation
is settrue
andsize
is not a multiple of4
, aRangeError
exception is thrown.See https://developer.chrome.com/blog/new-in-webgpu-138#size_requirement_changes_for_buffers_mapped_at_creation.
This PR adds a data point for the change.
Test results and supporting details
Related issues