Skip to content

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented Oct 28, 2025

Summary

Fixes the spec_url_value pattern in the compat data schema to allow spec URLs without a fragment.

Test results and supporting details

See failing check: https://github.com/mdn/browser-compat-data/actions/runs/18875856784/job/53865336337?pr=28219#step:5:33

JSON Schema - 3 problems (3 errors, 0 warnings):
 ✖ http/headers/Idempotency-Key.json - Error → PATTERN must match pattern "(^https://[^#]+#.+)|(^https://github.com/WebAssembly/.+)|(^[https://registry.khronos.org/webgl/extensions/[^/]+/)](https://registry.khronos.org/webgl/extensions/[%5E/]+/))"

  4 |       "Idempotency-Key": {
  5 |         "__compat": {
> 6 |           "spec_url": "https://datatracker.ietf.org/doc/html/draft-ietf-httpapi-idempotency-key-header/",
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  pattern must match pattern "(^https://[^#]+#.+)|(^https://github.com/WebAssembly/.+)|(^[https://registry.khronos.org/webgl/extensions/[^/]+/)](https://registry.khronos.org/webgl/extensions/[%5E/]+/))"
  7 |           "support": {
  8 |             "chrome": {
  9 |               "version_added": false
 ✖ http/headers/Idempotency-Key.json - Error → TYPE must be array

Related issues

Blocks #28219.

@caugner caugner requested a review from Elchi3 October 28, 2025 13:29
@caugner caugner requested a review from a team as a code owner October 28, 2025 13:29
@github-actions github-actions bot added schema Isses or pull requests regarding the JSON schema files used in this project. size:xs [PR only] 0-6 LoC changed labels Oct 28, 2025
@github-actions
Copy link
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea behind forcing us to add fragments is that we always deep link to definitions. This has worked quite well in the past I think. Hesitant to move away from this practice.

The deep link for the HTTP header in question would be https://datatracker.ietf.org/doc/html/draft-ietf-httpapi-idempotency-key-header/#name-the-idempotency-key-http-re

@caugner caugner closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

schema Isses or pull requests regarding the JSON schema files used in this project. size:xs [PR only] 0-6 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants