-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Chrome 143 WebGPU texture-component-swizzle feature #28411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Chrome 143 WebGPU texture-component-swizzle feature #28411
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Note that this will be partially fixed by #28226, so some of the statements will become "mirror" again, except the ones where Chrome has two notes. |
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to run npm ci && npm run fix once on this branch, which will revert some now Chrome Android statements to mirror.
As for other changes, I left some comments. (Sorry, reviewed last week and missed to submit.)
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Thanks! I ran the command as suggested and also added a missing comma. |
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we extract the other changes to a separate PR?
This should be straight-forward:
- Copy the branch (
git checkout -b webgpu-fixes) - Remove the
swizzlefeatures in that branch.
Then we can merge that PR first, afterwards merge main into this one, which would only leave adding the new swizzle features.
| "chrome_android": "mirror", | ||
| "chrome_android": { | ||
| "version_added": "139", | ||
| "notes": "Available on all adapters and enabled automatically on all devices even if not requested." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this is note is pre-existing, but what does it mean for web developers? Are there certain things that don't work, and why does it not justify partial_implementation: true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a feature that represents the basic, core featureset of WebGPU without requesting any extra features or advanced featuresets (which may well follow in the future). It is always available unless your GPU Adapter is set to "compatibility mode". I'm not 100% sure why they needed a specific feature name to represent the feature status quo.
Sure. Done in #28525. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Summary
Chrome 143 adds support for the WebGPU
texture-component-swizzlefeature, which, when enabled, allows usage of thecreateView()method'sswizzleoption that allows developers to perform color swizzles.See https://chromestatus.com/feature/5110223547269120.
This PR adds a data point for both the feature and the option.
I also took this opportunity to clean up the rest of the Chrome feature data, as a bunch of the entries weren't quite right (the Chrome Android data shouldn't mirror Chrome when Chrome is marked partial implementation and has a note, neither of which are relevant to CxA).
Test results and supporting details
Related issues