Skip to content

Editorial review: Document <dialog> closeby attribute #39082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2025
Merged

Editorial review: Document <dialog> closeby attribute #39082

merged 5 commits into from
Apr 25, 2025

Conversation

chrisdavidmills
Copy link
Contributor

Description

Chrome 134 supports the closedby attribute of the <dialog> element: see https://chromestatus.com/feature/5097714453577728.

This PR documents the new attribute, plus the equivalent DOM property.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested review from a team as code owners April 11, 2025 16:14
@chrisdavidmills chrisdavidmills requested review from estelle and wbamberg and removed request for a team April 11, 2025 16:14
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs labels Apr 11, 2025
@chrisdavidmills chrisdavidmills changed the title Document <dialog> closeby attribute Technical review: Document <dialog> closeby attribute Apr 11, 2025
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Apr 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

Preview URLs

Flaws (16)

URL: /en-US/docs/Web/API/HTMLDialogElement
Title: HTMLDialogElement
Flaw count: 6

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/select which is a redirect
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/HTMLDialogElement/closedBy
Title: HTMLDialogElement: closedBy property
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect

URL: /en-US/docs/Web/HTML/Reference/Elements/dialog
Title: <dialog>: The Dialog element
Flaw count: 8

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/form which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/form which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/select which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • and 3 more flaws omitted

(comment last updated: 2025-04-24 16:17:04)

mfreed7
mfreed7 reviewed Apr 14, 2025
View reviewed changes
Copy link

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for documenting this.

@chrisdavidmills chrisdavidmills requested a review from mfreed7 April 15, 2025 09:36
@chrisdavidmills chrisdavidmills changed the title Technical review: Document <dialog> closeby attribute Editorial review: Document <dialog> closeby attribute Apr 22, 2025
wbamberg
wbamberg reviewed Apr 23, 2025
View reviewed changes
estelle
estelle reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add the "closeBy" to another example as well. It doesn't have to be only in the "comparison" example.

@chrisdavidmills chrisdavidmills requested a review from estelle April 24, 2025 14:53
wbamberg
wbamberg reviewed Apr 24, 2025
View reviewed changes
wbamberg
wbamberg approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine as far as I am concerned. Thanks for the updates, Chris!

estelle
estelle approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks! 🎉

@chrisdavidmills chrisdavidmills merged commit 2dfac35 into mdn:main Apr 25, 2025
8 checks passed
@chrisdavidmills chrisdavidmills deleted the dialog-closedby-attribute branch April 25, 2025 06:15
@lukewarlow
Copy link
Contributor

lukewarlow commented Apr 29, 2025 •
edited
Loading

Thanks for doing this, apologies my PR stalled. Belated LGTM

@hamishwillee
Copy link
Collaborator

Note, tweaked by #39321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@wbamberg wbamberg wbamberg approved these changes

@mfreed7 mfreed7 Awaiting requested review from mfreed7

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrisdavidmills @lukewarlow @hamishwillee @estelle @wbamberg @mfreed7