Reference for stage 2.7 intl-era-monthcode#42660
Merged
Conversation
The Chinese calendar example incorrectly stated that year 2021 in the Chinese calendar corresponds to 616 BC in the ISO calendar. According to the TC39 Intl era and monthCode proposal, the Chinese calendar's epoch year is now ISO year 0, so year 2021 aligns with ISO year 2021. This commit: - Updates the Chinese calendar example comment to reflect the correct epoch year alignment - Corrects the expected output from "-000616-08-12[u-ca=chinese]" to "2021-08-08[u-ca=chinese]" - Adds a new Hebrew calendar example to demonstrate a calendar with a significantly different epoch year (5781 Hebrew = 2021 ISO) Fixes mdn#42565
github-actions
Bot
added
Content:JS
Contributor
Member
|
Hey, I'm going to add some more changes to this PR related to the calendar and month code changes. It's going to take some time but you don't have to worry about this. Thanks for sending this in! |
Contributor
Author
Sounds good, thanks for taking this on! Let me know if you need anything from my side. |
github-actions
Bot
added
system
Josh-Cena
changed the title
This was referenced Jan 24, 2026
Member
|
Asked for feedback from @ben-allen |
ben-allen
reviewed
Jan 28, 2026
Contributor
ben-allen
left a comment
ben-allen
left a comment
There was a problem hiding this comment.
looks good! I've left a few notes -- once this lands I'm going to go through and do another round of era/monthCode updates, since there's been some significant changes in the past couple of months.
Member
|
@ben-allen sorry for the wait; PTAL, thanks! |
Contributor
|
LGTM! |
Josh-Cena
approved these changes
Feb 17, 2026
pranjal2004838
pushed a commit
to pranjal2004838/content
that referenced
this pull request
Feb 25, 2026
* Fix incorrect Chinese calendar example in Temporal.PlainDate.from docs The Chinese calendar example incorrectly stated that year 2021 in the Chinese calendar corresponds to 616 BC in the ISO calendar. According to the TC39 Intl era and monthCode proposal, the Chinese calendar's epoch year is now ISO year 0, so year 2021 aligns with ISO year 2021. This commit: - Updates the Chinese calendar example comment to reflect the correct epoch year alignment - Corrects the expected output from "-000616-08-12[u-ca=chinese]" to "2021-08-08[u-ca=chinese]" - Adds a new Hebrew calendar example to demonstrate a calendar with a significantly different epoch year (5781 Hebrew = 2021 ISO) Fixes mdn#42565 * Fully document eras and monthCodes * Fixes --------- Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42565.
This PR documents the following changes specified by Intl era and monthCode:
hebrew)"bc"and"bce"instead of"gregory"and"gregory-inverse"Intl.supportedValuesOftable