Skip to content

Conversation

@yin1999
Copy link
Member

@yin1999 yin1999 commented Oct 8, 2025

Description

remove the leading space of the first paragraph in note card

Motivation

This PR reflects the changes made in yari, see: mdn/yari#10168 (review)

@yin1999 yin1999 requested a review from a team as a code owner October 8, 2025 08:21
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the space really wrong, or should it just not be displayed? I'm asking to understand if we should fix this in Fred instead.

(I'm not sure if rari has other locale-specific tweaks like this.)

/cc @argl

@yin1999
Copy link
Member Author

yin1999 commented Oct 15, 2025

Is the space really wrong, or should it just not be displayed?

For Chinese documents, there should be no spaces here. See: https://aubreyyung.com/space-between-chinese-words/#:~:text=No%20space%20after%20punctuation.%20(NB!%20Chinese%20punctuation%20marks%20have%20the%20same%20width%20as%20a%20Chinese%20character)

If the space can be excluded when copying and reading (including in accessible ways), then it is acceptable to implement it in fred.

@caugner caugner changed the title fix(md): remove the leading space of the first paragraph in note card fix(notecard): remove leading space of first paragraph in Chinese Oct 23, 2025
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but requesting a second opinion from @argl.

@caugner caugner requested a review from argl October 23, 2025 12:20
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@argl argl merged commit 25036cb into mdn:main Oct 23, 2025
1 check passed
@yin1999 yin1999 deleted the note-card-zh branch October 23, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants