-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: respect .remarkignore
at the same time
#561
Conversation
🦋 Changeset detectedLatest commit: 7b279f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
aa6a3e0
to
9273ae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
packages/eslint-mdx/src/worker.ts:253
- Consider extracting the result of ignoreCheckCache.get(cwd) into a local variable before invoking it. This can improve readability and make it easier to handle cases where the cached function might be undefined.
if (await ignoreCheckCache.get(cwd)(filePath)) {
packages/eslint-mdx/src/worker.ts:105
- [nitpick] Using a mutable top-level variable for the Ignore class can be error-prone; consider importing and assigning it to a local constant inside the getRemarkConfig function to improve clarity and reduce potential side effects in concurrent scenarios.
;({ Ignore } = (await import(
Initial checklist
Description of changes
close #502
Waiting for unifiedjs/unified-engine#79