Skip to content

Implement the experimental feature for remote federated search requests. #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 21, 2025

Conversation

consoleLogIt
Copy link
Contributor

Pull Request

Related issue

Fixes #1872

What does this PR do?

Implement the experimental feature for remote federated search requests.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@consoleLogIt consoleLogIt changed the title Kishan/remote federated search Implement the experimental feature for remote federated search requests. Mar 9, 2025
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (d6446f5) to head (9bd16a5).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1891   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          16       16           
  Lines        1566     1575    +9     
  Branches      343      345    +2     
=======================================
+ Hits         1556     1565    +9     
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@consoleLogIt
Copy link
Contributor Author

Hi @flevi29 @Strift, I created this PR last week and was wondering if there are any updates on it. Please let me know if there's something i need to update. Thanks!

@curquiza curquiza added the enhancement New feature or request label Mar 19, 2025
@curquiza curquiza requested review from flevi29 and Strift March 19, 2025 12:50
Strift
Strift previously requested changes Mar 20, 2025
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @consoleLogIt thanks for your PR!

I left a comment in the review. Please take a look at why the tests are failing

@consoleLogIt
Copy link
Contributor Author

Hi @Strift, this may not be an issue but when i run the style check locally i get this following error.
image

@flevi29 flevi29 requested a review from Strift March 20, 2025 19:30
Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@consoleLogIt I applied some changes. I think it's better to be closer to the main API as far as methods go, and the GET method was missing. The rest LGTM for now.

@Strift Strift dismissed their stale review March 21, 2025 08:23

Renamed the method as requested

Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @flevi29, this is much better.

bors merge

Copy link
Contributor

meili-bors bot commented Mar 21, 2025

@meili-bors meili-bors bot merged commit f93c639 into meilisearch:main Mar 21, 2025
8 checks passed
@consoleLogIt
Copy link
Contributor Author

Thanks for the review guys!
@flevi29 yeah that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.13] Remote federated search requests (experimental)
4 participants