-
Notifications
You must be signed in to change notification settings - Fork 91
Implement the experimental feature for remote federated search requests. #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the experimental feature for remote federated search requests. #1891
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 16 16
Lines 1566 1575 +9
Branches 343 345 +2
=======================================
+ Hits 1556 1565 +9
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @consoleLogIt thanks for your PR!
I left a comment in the review. Please take a look at why the tests are failing
…into kishan/remoteFederatedSearch
…soleLogIt/meilisearch-js into kishan/remoteFederatedSearch
Hi @Strift, this may not be an issue but when i run the style check locally i get this following error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@consoleLogIt I applied some changes. I think it's better to be closer to the main API as far as methods go, and the GET method was missing. The rest LGTM for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @flevi29, this is much better.
bors merge
Thanks for the review guys! |
Pull Request
Related issue
Fixes #1872
What does this PR do?
Implement the experimental feature for remote federated search requests.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!