-
Notifications
You must be signed in to change notification settings - Fork 92
Drop Node 18 support #1927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Drop Node 18 support #1927
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1927 +/- ##
==========================================
- Coverage 99.03% 99.02% -0.01%
==========================================
Files 18 18
Lines 1449 1438 -11
Branches 305 301 -4
==========================================
- Hits 1435 1424 -11
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WalkthroughThe changes update the minimum supported Node.js version from 18 to 20 across documentation, CI workflows, Docker configuration, TypeScript, and build tooling. Code previously accommodating Node.js 18 polyfills is removed. Build and test targets are updated to ES2023 and Node.js 20/22. Minor internal symbol changes improve timeout error identification. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI System
participant Node.js Environment
Developer->>CONTRIBUTING.md: Reads requirements (Node.js 20+)
CI System->>Node.js Environment: Runs tests on Node.js 20 and 22
CI System->>docker-compose.yml: Uses node:22 image
Developer->>tsconfig.json: Compiles with ES2023 target
Developer->>vite.config.ts: Builds with ES2023 target
src/token.ts->>Global Crypto: Uses crypto directly (no polyfill)
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
💤 Files with no reviewable changes (1)
🔇 Additional comments (10)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Pull Request
What does this PR do?
is about to enterentered End Of Life period, so it's time to drop support:https://github.com/nodejs/Release?tab=readme-ov-file#release-schedulehttps://github.com/nodejs/Release?tab=readme-ov-file#end-of-life-releasesToken generation and aborting requests might stop working for Node.js 18 users.
Summary by CodeRabbit