-
Notifications
You must be signed in to change notification settings - Fork 100
Add disableOnNumbers
field to typo tolerance settings
#753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bump-meilisearch-v1.15.0
Are you sure you want to change the base?
Add disableOnNumbers
field to typo tolerance settings
#753
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes update documentation and test cases to reflect a new boolean property, Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
disableOnNumbers
field to typo tolerance settings
I'm not sure if you are requesting changes in this PR or not. As per #749, we agreed to release v1.15 (which includes Meilisearch v1.15 changes) before handling the release of v2.0. So I'm thinking we can either rebase or merge main in the v2 branch after releasing this. Let me know if I misunderstood something. 🙏 |
Yes, I just noted to don't forget :) |
Pull Request
This PR updates the typo tolerance settings to allow deactivating typo tolerance on high entropy words.
Related engine issue: meilisearch/meilisearch#5344
What does this PR do?
disableOnNumbers
field to typo tolerance settingsPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
Documentation
disableOnNumbers
.Tests
disableOnNumbers
option in typo tolerance settings, ensuring it is correctly handled and defaults tofalse
.